From 310f4b9b1a6864300aa22cd6342abd8688c39bc9 Mon Sep 17 00:00:00 2001 From: Francis Charette Migneault Date: Fri, 22 Nov 2024 10:29:55 -0500 Subject: [PATCH 1/2] attempt swap order of coverage actions --- .github/workflows/tests.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index aab149e47..cd7fbb022 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -131,13 +131,6 @@ jobs: - name: Run Tests run: make stop ${{ matrix.test-case }} - - name: Upload test results to Codecov - if: ${{ !cancelled() && success() && matrix.test-case == 'test-coverage-only' }} - uses: codecov/test-results-action@v1 - with: - files: reports/coverage-junit.xml,!./cache - flags: ${{ matrix.python-version }} - token: ${{ secrets.CODECOV_TOKEN }} - name: Upload coverage report uses: codecov/codecov-action@v2 if: ${{ success() && matrix.test-case == 'test-coverage-only' }} @@ -146,6 +139,13 @@ jobs: files: ./reports/coverage.xml fail_ci_if_error: true verbose: true + - name: Upload test results to Codecov + if: ${{ !cancelled() && success() && matrix.test-case == 'test-coverage-only' }} + uses: codecov/test-results-action@v1 + with: + files: reports/coverage-junit.xml,!./cache + flags: ${{ matrix.python-version }} + token: ${{ secrets.CODECOV_TOKEN }} deploy-docker: needs: tests From f24885728713b715b474bd15ecc6a5d3ccd5b11d Mon Sep 17 00:00:00 2001 From: Francis Charette Migneault Date: Fri, 22 Nov 2024 18:41:28 -0500 Subject: [PATCH 2/2] disable codecov test analytics to bring back useful coverage reports (relates to https://github.com/codecov/feedback/issues/304#issuecomment-2492675117) --- .github/workflows/tests.yml | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index cd7fbb022..16997e631 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -131,6 +131,15 @@ jobs: - name: Run Tests run: make stop ${{ matrix.test-case }} + # disable due to confusing and unhelpful messages created by codecov + # (see )https://github.com/codecov/feedback/issues/304#issuecomment-2492675117) + # - name: Upload test results to Codecov + # if: ${{ !cancelled() && success() && matrix.test-case == 'test-coverage-only' }} + # uses: codecov/test-results-action@v1 + # with: + # files: reports/coverage-junit.xml,!./cache + # flags: ${{ matrix.python-version }} + # token: ${{ secrets.CODECOV_TOKEN }} - name: Upload coverage report uses: codecov/codecov-action@v2 if: ${{ success() && matrix.test-case == 'test-coverage-only' }} @@ -139,13 +148,6 @@ jobs: files: ./reports/coverage.xml fail_ci_if_error: true verbose: true - - name: Upload test results to Codecov - if: ${{ !cancelled() && success() && matrix.test-case == 'test-coverage-only' }} - uses: codecov/test-results-action@v1 - with: - files: reports/coverage-junit.xml,!./cache - flags: ${{ matrix.python-version }} - token: ${{ secrets.CODECOV_TOKEN }} deploy-docker: needs: tests