Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Job status inconsistencies #145

Closed
fmigneault opened this issue May 15, 2020 · 0 comments · Fixed by #346
Closed

[BUG] Job status inconsistencies #145

fmigneault opened this issue May 15, 2020 · 0 comments · Fixed by #346
Assignees
Labels
feature/job Issues related to job execution, reporting and logging. triage/bug Something isn't working triage/conformance Issue related to fixing/ensuring compliance to specifications.

Comments

@fmigneault
Copy link
Collaborator

fmigneault commented May 15, 2020

When a submitted process is just picked up by celery, it should report running status. Sometimes it does so for a brief moment when calling GET /processes/{id}/job/{id}, but doing a subsequent calls, the process returns to accepted status. This is probably due to the status mapper trying to be compliant to some status names that do not include running, which falls back to accepted.

Once the process has been correctly picked up and set to running, it must remain as such until it transits to failed/succeeded/dismissed accordingly.

As per OGC reference, the succeeded status is named successful. This should be adjusted to respect the standard. Internally we should still verify all variations to make sure.
https://raw.githubusercontent.com/opengeospatial/wps-rest-binding/master/core/openapi/schemas/statusInfo.yaml

The same above reference also shows that OGC now considers dismissed as a valid status. It should be added to the OGC status mapping, and mapping function should be updated accordingly.

STATUS_COMPLIANT_OGC: frozenset([STATUS_ACCEPTED, STATUS_RUNNING, STATUS_SUCCEEDED, STATUS_FAILED]), # noqa: E241, E501

Must had a test that validates this transition of status more explicitly.
Similar procedure as for following test should be used, but calling get-job-status at fast intervals (no delays) to attempt catching brief/sporadic status transitions.

def test_jsonarray2netcdf_execute(self):

@fmigneault fmigneault added triage/bug Something isn't working triage/conformance Issue related to fixing/ensuring compliance to specifications. feature/job Issues related to job execution, reporting and logging. labels May 15, 2020
@fmigneault fmigneault self-assigned this May 15, 2020
@github-actions github-actions bot removed the triage/bug Something isn't working label May 15, 2020
@fmigneault fmigneault added the triage/bug Something isn't working label Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/job Issues related to job execution, reporting and logging. triage/bug Something isn't working triage/conformance Issue related to fixing/ensuring compliance to specifications.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant