Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suddenly unusable on CircleCI "machine" VMs #1264

Closed
4 of 11 tasks
nullchinchilla opened this issue May 23, 2023 · 4 comments · Fixed by #1265
Closed
4 of 11 tasks

Suddenly unusable on CircleCI "machine" VMs #1264

nullchinchilla opened this issue May 23, 2023 · 4 comments · Fixed by #1265
Labels
A-linux-host Area: linux hosts upstream

Comments

@nullchinchilla
Copy link

Checklist

Describe your issue

I use CircleCI to run cross-compile jobs using cross for Geph. To avoid the complications of docker-in-docker, I've always used the "machine" class, which spins up a full virtual machine.

Recently, my build scripts have suddenly started failing with this error:

#!/bin/bash -eo pipefail
cross build --release --locked  --target armv7-unknown-linux-musleabihf
Error: 
   0: Ctrl-C error: Ctrl-C signal handler already registered

Exited with code exit status 1
CircleCI received exit code 1

This happened even though the cross utility did not change versions, and my build script did not change. I suspect it's some issue with the docker container itself; it looks like some conflict with whatever code handles "ctrl+c" gracefully shutting down the docker container, conflicting with a signal handler that circleci attaches, possibly to handle the "stop compile" button.

What target(s) are you cross-compiling for?

No response

Which operating system is the host (e.g computer cross is on) running?

  • macOS
  • Windows
  • Linux / BSD
  • other OS (specify in description)

What architecture is the host?

  • x86_64 / AMD64
  • arm32
  • arm64 (including Mac M1)

What container engine is cross using?

  • docker
  • podman
  • other container engine (specify in description)

cross version

cross 0.2.5

Example

No response

Additional information / notes

No response

@Emilgardis Emilgardis added upstream A-linux-host Area: linux hosts labels May 23, 2023
@Emilgardis
Copy link
Member

There was a change recently in the ctrlc crate

Detegr/rust-ctrlc#97

Detegr/rust-ctrlc@7a23454

I'm not sure what we can do about this.
Maybe we can make this a soft error?

For now, install cross with cargo install cross --locked to ensure the versions you use are the same as they were during publication.

@Emilgardis
Copy link
Member

This is not fixed on 0.2.5 unless you use --locked to install

@ekampf
Copy link

ekampf commented May 23, 2023

@Emilgardis any chance you can release new docker images with this fix?

@Emilgardis
Copy link
Member

Emilgardis commented May 23, 2023

I'm not sure I understand the request @ekampf the images for the main branch are rebuilt weekly https://github.com/cross-rs/cross/actions/runs/5019408894 currently we have some images failing though, need #1208

the fix is not in the docker images, it's on the CLI tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linux-host Area: linux hosts upstream
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants