From 64e66eacda4d848423b721c65b539e3c23efe6eb Mon Sep 17 00:00:00 2001 From: Christopher Haar Date: Thu, 17 Jun 2021 10:25:55 +0200 Subject: [PATCH] fix sfn 404 for deletion Signed-off-by: Christopher Haar --- apis/sfn/v1alpha1/generator-config.yaml | 10 ++++++---- pkg/controller/sfn/activity/zz_conversions.go | 2 +- pkg/controller/sfn/statemachine/zz_conversions.go | 2 +- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/apis/sfn/v1alpha1/generator-config.yaml b/apis/sfn/v1alpha1/generator-config.yaml index bfaa9dc7c9..073876d814 100644 --- a/apis/sfn/v1alpha1/generator-config.yaml +++ b/apis/sfn/v1alpha1/generator-config.yaml @@ -5,9 +5,11 @@ ignore: resources: StateMachine: exceptions: - codes: - 404: StateMachineDoesNotExist + errors: + 404: + code: StateMachineDoesNotExist Activity: exceptions: - codes: - 404: ActivityDoesNotExist \ No newline at end of file + errors: + 404: + code: ActivityDoesNotExist \ No newline at end of file diff --git a/pkg/controller/sfn/activity/zz_conversions.go b/pkg/controller/sfn/activity/zz_conversions.go index ec1e9e1a4d..00782385c9 100644 --- a/pkg/controller/sfn/activity/zz_conversions.go +++ b/pkg/controller/sfn/activity/zz_conversions.go @@ -98,5 +98,5 @@ func GenerateDeleteActivityInput(cr *svcapitypes.Activity) *svcsdk.DeleteActivit // IsNotFound returns whether the given error is of type NotFound or not. func IsNotFound(err error) bool { awsErr, ok := err.(awserr.Error) - return ok && awsErr.Code() == "UNKNOWN" + return ok && awsErr.Code() == "ActivityDoesNotExist" } diff --git a/pkg/controller/sfn/statemachine/zz_conversions.go b/pkg/controller/sfn/statemachine/zz_conversions.go index 6133d385ee..0969a4acb0 100644 --- a/pkg/controller/sfn/statemachine/zz_conversions.go +++ b/pkg/controller/sfn/statemachine/zz_conversions.go @@ -179,5 +179,5 @@ func GenerateDeleteStateMachineInput(cr *svcapitypes.StateMachine) *svcsdk.Delet // IsNotFound returns whether the given error is of type NotFound or not. func IsNotFound(err error) bool { awsErr, ok := err.(awserr.Error) - return ok && awsErr.Code() == "UNKNOWN" + return ok && awsErr.Code() == "StateMachineDoesNotExist" }