Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observe Only - Kubernetes < 1.25 they will no longer get a validation error at the API server level #693

Closed
haarchri opened this issue May 4, 2023 · 3 comments

Comments

@haarchri
Copy link
Member

haarchri commented May 4, 2023

What problem are you facing?

since #672 is merged - we missing some information in readme about this fact:
crossplane/crossplane#3531 (comment)

Once we do this change here for a given resource, Observe Only resources would immediately work without needing all required fields to be provided, whether CEL is available or not. What users with k8s <= 1.24 (without the alpha feature enabled) lose is that when, management policy is not ObserveOnly, they will no longer get a validation error at the API server level, during CR creation when they didn't provide a required field.

This would definitely be a UX degradation; however, it shouldn't be a huge deal assuming the reconciler will report the error from cloud API indicating that a required field is missing.

for example:
AWS EKS - 1.24 end of support in January 2024
https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html

@turkenh
Copy link
Contributor

turkenh commented May 5, 2023

@haarchri, thanks for the ticket, and sorry for the inconvenience.

Yes, this is expected behavior.
Would adding this information to the provider readme's and in the release notes for the relevant release be sufficient? Do you have other places in mind?

Copy link

github-actions bot commented Apr 6, 2024

This provider repo does not have enough maintainers to address every issue. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@github-actions github-actions bot added the stale label Apr 6, 2024
Copy link

This issue is being closed since there has been no activity for 14 days since marking it as stale. If you still need help, feel free to comment or reopen the issue!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants