From 55a8c109304f3a03509216fb366230d965236c40 Mon Sep 17 00:00:00 2001 From: lsviben Date: Wed, 20 Sep 2023 11:46:19 +0200 Subject: [PATCH] gmp to beta Signed-off-by: lsviben --- apis/common/v1/resource.go | 5 ++--- pkg/feature/features.go | 4 ++-- pkg/reconciler/managed/reconciler.go | 4 ++-- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/apis/common/v1/resource.go b/apis/common/v1/resource.go index 5e40a560f..83b6f12d1 100644 --- a/apis/common/v1/resource.go +++ b/apis/common/v1/resource.go @@ -197,9 +197,8 @@ type ResourceSpec struct { // +kubebuilder:default={"name": "default"} ProviderConfigReference *Reference `json:"providerConfigRef,omitempty"` - // THIS IS AN ALPHA FIELD. Do not use it in production. It is not honored - // unless the relevant Crossplane feature flag is enabled, and may be - // changed or removed without notice. + // THIS IS A BETA FIELD. It is on by default but can be opted out + // through a Crossplane feature flag. // ManagementPolicies specify the array of actions Crossplane is allowed to // take on the managed and external resources. // This field is planned to replace the DeletionPolicy field in a future diff --git a/pkg/feature/features.go b/pkg/feature/features.go index a88161737..7a93d22e6 100644 --- a/pkg/feature/features.go +++ b/pkg/feature/features.go @@ -16,7 +16,7 @@ limitations under the License. package feature -// EnableAlphaManagementPolicies enables alpha support for +// EnableBetaManagementPolicies enables beta support for // Management Policies. See the below design for more details. // https://github.com/crossplane/crossplane/pull/3531 -const EnableAlphaManagementPolicies Flag = "EnableAlphaManagementPolicies" +const EnableBetaManagementPolicies Flag = "EnableBetaManagementPolicies" diff --git a/pkg/reconciler/managed/reconciler.go b/pkg/reconciler/managed/reconciler.go index 8624069fe..f340f680a 100644 --- a/pkg/reconciler/managed/reconciler.go +++ b/pkg/reconciler/managed/reconciler.go @@ -660,7 +660,7 @@ func WithRecorder(er event.Recorder) ReconcilerOption { // WithManagementPolicies enables support for management policies. func WithManagementPolicies() ReconcilerOption { return func(r *Reconciler) { - r.features.Enable(feature.EnableAlphaManagementPolicies) + r.features.Enable(feature.EnableBetaManagementPolicies) } } @@ -752,7 +752,7 @@ func (r *Reconciler) Reconcile(ctx context.Context, req reconcile.Request) (resu "external-name", meta.GetExternalName(managed), ) - managementPoliciesEnabled := r.features.Enabled(feature.EnableAlphaManagementPolicies) + managementPoliciesEnabled := r.features.Enabled(feature.EnableBetaManagementPolicies) if managementPoliciesEnabled { log.WithValues("managementPolicies", managed.GetManagementPolicies()) }