Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent resource skip-list relevant messages from appearing in the provider logs #81

Closed
ulucinar opened this issue Aug 26, 2022 · 1 comment · Fixed by #86
Closed

Prevent resource skip-list relevant messages from appearing in the provider logs #81

ulucinar opened this issue Aug 26, 2022 · 1 comment · Fixed by #86
Assignees
Labels
enhancement New feature or request

Comments

@ulucinar
Copy link
Collaborator

ulucinar commented Aug 26, 2022

What problem are you facing?

We are employing a list to skip a set of Terraform resources in our various code generation pipelines. And relevant messages appear in the provider logs as we also load the resource configuration at runtime. This may be confusing for customers (as I would say it's our implementation detail, what's important is the set of CRDs (managed resources) available in our documentation):
As reported by @luebken:

$ kubectl logs -n upbound-system
provider-aws-72c9a31335c5-54976c54d6-p45t7
Skipping resource aws_iam_role_policy because it is in SkipList
....

How could Terrajet help solve your problem?

We can prevent the relevant messages in the provider logs but keep them in the generator logs.

@ulucinar ulucinar added the enhancement New feature or request label Aug 26, 2022
@negz
Copy link
Member

negz commented Aug 26, 2022

My two cents: anything that would be useful in helping a developer debug these providers should be logged at debug level (such that it only shows up when the --debug flag is provided). I think it's fair game for things end users might not understand (like this) to show up there. It definitely shouldn't be logged by default / at info though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants