[Bug] GraphElement with ID 'cryostat-target-topology-graph' has no controller

[andrewazores]

Current Behavior

The Topology view causes this error to appear in the browser console. In dev mode it causes the page to blow up with a webpack-dev-server "uncaught runtime error" overlay.

See discussions in #120

Expected Behavior

No response

Steps To Reproduce

No response

Environment

Anything else?

No response

[andrewazores]

Labelled as a P2 (low priority, non-blocking) for 4.0 release since in full production builds/deployments it seems to be mostly harmless. If we find that it does cause runtime problems in production mode then this can be upgraded to a P1 or P0.

[tthvo]

Previously caught during PF5 upgrade: cryostatio/cryostat-web#1334 (comment). I thought this PR cryostatio/cryostat-web#1336 would have fixed it but seems like it didnt :(

[aptmac]

I've found something that works at the moment, just giving it a build and test against crc instead of smoketest.

I think it's this line in TopologyGraphView: https://github.com/cryostatio/cryostat-web/blob/main/src/app/Topology/GraphView/TopologyGraphView.tsx#L192

    // Initialize the controller with model to create nodes
    visualization.fromModel(model, false);

Changing the false -> true results in the stale elements being removed once all the new elements are created, and this fixes.

---

Background

When we set false above, Visualization immediately does a clear out of old elements (https://github.com/patternfly/react-topology/blob/dc28e8bf77e363eda3507a6b547ecafaa916a611/packages/module/src/Visualization.ts#L99), which ultimately results in the controller being set to undefined for the element (https://github.com/patternfly/react-topology/blob/dc28e8bf77e363eda3507a6b547ecafaa916a611/packages/module/src/Visualization.ts#L223, https://github.com/patternfly/react-topology/blob/main/packages/module/src/elements/BaseElement.ts#L95).

And this is where we see the stack trace on the ui. Ending the Cola Layout
Around the same time, ending the cola layout ends up looking for the controller of the BaseElement and throws the error because it's undefined.

[tthvo]

Oh nice, that makes sense to me!!

[andrewazores]

Previously caught during PF5 upgrade: cryostatio/cryostat-web#1334 (comment). I thought this PR cryostatio/cryostat-web#1336 would have fixed it but seems like it didnt :(

I have absolutely zero memory of that, clearly 😁

[tthvo]

This is great! This issue has been bugging me for a while since PF5 upgrade. Finally off my mind haha :D