Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: filter api missing events when internal websocket client reconnect #665

Open
yihuang opened this issue Aug 23, 2022 · 2 comments
Open
Assignees
Labels
blocked blocked by another issue

Comments

@yihuang
Copy link
Collaborator

yihuang commented Aug 23, 2022

@mmsqe found that the reason for the mempool test failure is due to internal ws connection reconnect occasionally, when that happens, the API lose messages.

@yihuang yihuang changed the title Problem: filter api missing events when internal ws reconnect Problem: filter api missing events when internal websocket client reconnect Aug 23, 2022
@mmsqe
Copy link
Collaborator

mmsqe commented Aug 26, 2022

since No way to detect data loss based on current desgin, not sure if we can deprecate websocket and switch to long poll on events endpoint with after cursor, starting 1st perf improve, need backport rest one by one

@yihuang
Copy link
Collaborator Author

yihuang commented Aug 26, 2022

since No way to detect data loss based on current desgin, not sure if we can deprecate websocket and switch to long poll on events endpoint with after cursor, starting 1st perf improve

yeah, that's the plan tendermint/tendermint#9305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked blocked by another issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@yihuang @mmsqe and others