-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specter export does not contain hardware wallet type #1176
Comments
I described a similar approach here: And implemented it in #1109 but that work is held up by some refactoring that's needed in the UI layer. Maybe I should make that PR less ambitious and at least pull out the device type and name changes into their own PR. |
@kdmukai Your suggestion is certainly better than mine - Sparrow could use the labels too. Would be great to see this implemented. |
Hi, yes I agree it will be nicer with this format. @kdmukai what is the status with your PR currently? |
@ben-kaufman I'll separate out the backup format changes into a smaller PR. Hopefully in the next few days. Then I'll see where the wizard UI code is at. If it still needs refactoring, I'll take a stab at that next. That'll be a big lift. Then it'll be easy to finally incorporate the hot wallet restore flow. |
Thanks, I've added support for the |
While the export file (created from
Wallets > Settings > Export to Wallet Software
in Specter Desktop) contains sufficient information to reproduce a wallet as a watch only wallet, it does not contain information about the type of devices used to create it.Practically this means that users need to reimport their hardware wallet after importing this file, since there is no way to tell what kind of interface to present to the user (for example when they want to sign a transaction). This is a common support request for Sparrow users.
As a suggestion, the JSON could contain an extra field which lists the devices in the order they appear in the descriptor:
HWI already has a standard set of names which could be adopted.
The text was updated successfully, but these errors were encountered: