Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add X25519MLKEM768 hybrid key agreement option #125

Merged
merged 6 commits into from
Nov 26, 2024

Conversation

jschneider-bensch
Copy link
Contributor

This PR addresses the addition of an ML-KEM based hybrid key agreement described in issue #124 .

More specifically, it uses the libcrux implementation of X25519MLKEM768 to offer one new ciphersuite

/// `TLS_CHACHA20_POLY1305_SHA256`
/// with
/// * X25519MlKem768 for key exchange (cf. https://datatracker.ietf.org/doc/draft-kwiatkowski-tls-ecdhe-mlkem/)
/// * EcDSA P256 SHA256 for signatures
pub const SHA256_Chacha20Poly1305_EcdsaSecp256r1Sha256_X25519MlKem768: Algorithms = Algorithms::new(
    HashAlgorithm::SHA256,
    AeadAlgorithm::Chacha20Poly1305,
    SignatureScheme::EcdsaSecp256r1Sha256,
    KemScheme::X25519MlKem768,
    false,
    false,
);

It does not implement the SecP256r1MLKEM768 ciphersuite described by the Internet Draft.

Fixes #124

@jschneider-bensch jschneider-bensch requested a review from a team as a code owner November 20, 2024 14:12
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm when the name is fixed.

@franziskuskiefer
Copy link
Member

I manually triggered hax, which was auto-disabled. https://github.com/cryspen/bertie/actions/runs/12025538546/job/33522857963
Merging this without re-triggering everything.

@franziskuskiefer franziskuskiefer merged commit 1b90bcc into main Nov 26, 2024
11 checks passed
@franziskuskiefer franziskuskiefer deleted the jonas/x25519mlkem768-kem branch November 26, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ML-KEM ciphersuite
2 participants