Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monadic transformation is broken #822

Open
2 tasks
W95Psp opened this issue Aug 5, 2024 · 3 comments
Open
2 tasks

Monadic transformation is broken #822

W95Psp opened this issue Aug 5, 2024 · 3 comments
Labels
bug Something isn't working engine Issue in the engine

Comments

@W95Psp
Copy link
Collaborator

W95Psp commented Aug 5, 2024

* Error 54 at Sandwich.Tunnel.Tls.fsti(383,22-397,94):
  - Core.Ops.Control_flow.t_ControlFlow (Core.Result.t_Result Prims.unit Sandwich.Error.t_Error)
      (Prims.bool & Prims.bool) is not a subtype of the expected type Prims.bool & Prims.bool

1 error was reported (see above)

Action item:

  • throw an error instead of trying to transform, with hints to how to rewrite
  • fix the transformation
@W95Psp W95Psp added bug Something isn't working engine Issue in the engine labels Aug 5, 2024
@franziskuskiefer
Copy link
Member

Most cases should be covered by what's doing in #393. Let's assess if this is still needed when that's done.

Copy link

This issue has been marked as stale due to a lack of activity for 60 days. If you believe this issue is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale label Dec 14, 2024
@W95Psp W95Psp removed the stale label Dec 16, 2024
@W95Psp
Copy link
Collaborator Author

W95Psp commented Dec 16, 2024

We still need this phase: rewrite control flow introduces too many deduplication in certain case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working engine Issue in the engine
Projects
None yet
Development

No branches or pull requests

3 participants