Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-ASCII case conversion to String#upcase/downcase/swapcase/capitalize #2889

Closed
deepj opened this issue Jun 21, 2016 · 3 comments
Closed

Comments

@deepj
Copy link
Contributor

deepj commented Jun 21, 2016

It's same issue as in Ruby. See https://bugs.ruby-lang.org/issues/10085 and https://github.com/ruby/ruby/blob/trunk/NEWS

Basically, the current implementation of case conversion strings is currently limited to ASCII characters.

Now (Crystal 0.18.2, note lower-case ü):

 "Türkiye".upcase # =>  TüRKIYE

Would be:

"Türkiye".upcase # =>  TÜRKIYE
@asterite
Copy link
Member

Yes, I think we'll eventually do it, but it's very hard.

Duplicate of #1648

@deepj
Copy link
Contributor Author

deepj commented Jun 21, 2016

@asterite Ah, thanks for notice, second duplicate here :)

@asterite
Copy link
Member

@deepj No worries about duplicates, sometimes they are hard to find because different words are used. Duplicates mean there's interest on those issues so they help :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants