Compress handler returns empty body for HTTP server #4064

ukd1 · 2017-02-23T03:33:00Z

Possibly related to #4060, @ezrast and I found when hacking -when using the compress handler, the response has no body when using curl or browsers; removing the accept encoding headers, things work as expected.

$ crystal -v
Crystal 0.21.0 (2017-02-21)

Code:

require "http/server"
require "http/server/handlers/compress_handler"

server = HTTP::Server.new("localhost", 3000, [HTTP::CompressHandler.new]
) do |context|
  context.response.status_code = 200
  context.response << %{
<html><body>
<p>HAI: #{context.request.path}.
</body></html>
}
end

puts "Launching server at http://localhost:3000"
puts "Press Ctrl+C to exit"
server.listen

Bug:

$ curl --compressed -vv http://localhost:3000/
*   Trying ::1...
* Connected to localhost (::1) port 3000 (#0)
> GET / HTTP/1.1
> Host: localhost:3000
> User-Agent: curl/7.49.1
> Accept: */*
> Accept-Encoding: deflate, gzip
> 
< HTTP/1.1 200 OK
< Connection: keep-alive
< Content-Encoding: gzip
< Content-Length: 54
< 
* Connection #0 to host localhost left intact

without compression things work as expected:

$ curl -vv http://localhost:3000/
*   Trying ::1...
* Connected to localhost (::1) port 3000 (#0)
> GET / HTTP/1.1
> Host: localhost:3000
> User-Agent: curl/7.49.1
> Accept: */*
> 
< HTTP/1.1 200 OK
< Connection: keep-alive
< Content-Length: 40
< 

<html><body>
<p>HAI: /.
</body></html>
* Connection #0 to host localhost left intact

The text was updated successfully, but these errors were encountered:

asterite · 2017-03-01T15:21:37Z

Fixed by #4068

ukd1 mentioned this issue Feb 23, 2017

Fixes #4060 #4068

Merged

spalladino added the kind:bug A bug in the code. Does not apply to documentation, specs, etc. label Feb 27, 2017

asterite added this to the Next milestone Mar 1, 2017

asterite added the topic:stdlib label Mar 1, 2017

asterite closed this as completed Mar 1, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compress handler returns empty body for HTTP server #4064

Compress handler returns empty body for HTTP server #4064

ukd1 commented Feb 23, 2017 •

edited

Loading

asterite commented Mar 1, 2017

Compress handler returns empty body for HTTP server #4064

Compress handler returns empty body for HTTP server #4064

Comments

ukd1 commented Feb 23, 2017 • edited Loading

asterite commented Mar 1, 2017

ukd1 commented Feb 23, 2017 •

edited

Loading