Allow Iterator.stop to be used inside Iterator.of block #4208
Conversation
|
|
||
| private def self.without_stop(&block : -> T) | ||
| e = block.call | ||
| raise "" if e.is_a?(Iterator::Stop) |
There was a problem hiding this comment.
This method isn't called, only used for typeof.
There was a problem hiding this comment.
Oh, I see. Still, raise "" (which internally translates to raise ArgumentError.new, no?) looks odd for me...
There was a problem hiding this comment.
No, raise "" = raise Exception.new
There was a problem hiding this comment.
So, why no raise Exception.new? Seems imo clearer.
There was a problem hiding this comment.
We just need a function that returns NoReturn. The same raise "" pattern is used in https://github.com/crystal-lang/crystal/blob/master/src/iterator.cr#L472 .
The code is never executed actually.
There was a problem hiding this comment.
Fair 'nuff, I just thought it looks odd aside of its actual function.
There was a problem hiding this comment.
We could find probably a more idiomatic way to express this. maybe a fail : NoReturn or halt or unreachable that will abort compilation at codegen but will return NoReturn in semantic could work better. #someday
bcardiff
added
topic:stdlib
kind:bug
Ref #4198 (comment)
Before PR using
Iterator.stopin the block given toIterator.ofwould generate a union between the expected type andIterator::Stop.