Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make @host publicly accessible such as @port is in HTTP::Server #4325

Closed
joaodiogocosta opened this issue Apr 22, 2017 · 2 comments
Closed

Comments

@joaodiogocosta
Copy link
Contributor

I would like to be able to access an http server's @host the same way I can access @PORT.
As of this moment, @host is a private variable of HTTP::Server and does not have accessor methods.

I would be happy to submit a PR if you find it suitable.

@bcardiff
Copy link
Member

bcardiff commented May 4, 2017

There is a draft for splitting http server and listeners in order to support binding to unix socket directly #2735. That could impact on the solution for this.

Note that the ip used to bind the server to is not the same as the ip of the server itself. 0.0.0.0 matching everything but not telling you the ip of the server.

@joaodiogocosta
Copy link
Contributor Author

@bcardiff I'll follow on #2735 and see what happens then. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants