raise(Exception): Setup callstack on raise only if not already set. #4487
Conversation
src/raise.cr
Outdated
| # Raises the *exception*. | ||
| # | ||
| # Note that exception callstack will only be set if it's not already set. | ||
| # It's useful for reraising of exceptions in `rescue` blocks. |
There was a problem hiding this comment.
Maybe the doc could be simpler? Maybe:
Raises an
Exception.This will set the exception's callstack if it hasn't been already. Re-raising a previously catched exception won't replace the callstack.
There was a problem hiding this comment.
I suppose that the article just fit here.
And thanks for rewording, will apply.
spec/std/raise_spec.cr
Outdated
| new_ex.callstack.should eq(callstack_to_match) | ||
| end | ||
|
|
||
| it "should throw exception with new callstack if not already set" do |
There was a problem hiding this comment.
Maybe it sets exception's callstack and it should come before the spec that says it doesn't overwrite the callback.
It's useful for reraising of exceptions in `rescue` blocks. As proposed by crystal-lang#4482 (comment). /cc @asterite, @straight-shoota.
akzhan
force-pushed
the
setup-callstack-on-raise-only-if-not-already-set
branch
from
b357676 to
82eb2d4
Compare
|
@ysbaddaden I believe that we should not depend in this example on the assumption that we get the same exception. |
|
Although you are right, this is absolutely superfluous |
…ion when it's rescued.
|
Thanks, @asterite . Now it looks cleaner. |
|
Thank you! |
|
@ysbaddaden would you mind setting the "Next" milestone to PRs when you merge them? It makes it easier for us to write release notes afterwards :) |
|
Oh ok, will do now! |
It's useful for reraising of exceptions in
rescueblocks.As proposed by #4482 (comment).
/cc @asterite, @straight-shoota.