Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heredoc with more than 300 lines fails to compile on Crystal 0.32.0 #8577

Closed
lbguilherme opened this issue Dec 11, 2019 · 1 comment
Closed

Comments

@lbguilherme
Copy link
Contributor

The recent Crystal 0.32.0 release includes the new String.interpolation as an alternative codegen for what used to be based on String.build (see #8400).

This is causing issues for me on heredocs with interpolation:

bug = <<-END
x
#{2}
x
x
... 300 more lines with just "x"...
x
x
END

Fails to compile with:

In /tmp/bug.cr:1:5

 1 | bug = <<-END
         ^------------
Error: instantiating 'String.class#interpolation(String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String)'


In /usr/share/crystal/src/string.cr:4536:27

 4536 | def self.interpolation(*values : String)
                                ^
Error: tuple size cannot be greater than 300 (size is 301)

I noticed from reading the parser that heredocs are represented as a StringInterpolation nodes with each line as a individual string in this case. I believe there should be an AST transformation on top of StringInterpolation that will merge any two successive string literals into one, avoiding the issue if I'm just writing a long heredoc. Is this the correct approach to fix this?

@lbguilherme
Copy link
Contributor Author

dup of #8576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant