From a1a1aaf751fd27322c85a3f0050da8f7b5c574d9 Mon Sep 17 00:00:00 2001 From: r00ster Date: Mon, 29 Oct 2018 12:18:09 +0100 Subject: [PATCH 1/2] Improve Contributors section --- spec/compiler/crystal/tools/init_spec.cr | 4 ++-- src/compiler/crystal/tools/init/template/readme.md.ecr | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/spec/compiler/crystal/tools/init_spec.cr b/spec/compiler/crystal/tools/init_spec.cr index 9e66e6c673f7..299121200aa3 100644 --- a/spec/compiler/crystal/tools/init_spec.cr +++ b/spec/compiler/crystal/tools/init_spec.cr @@ -104,7 +104,7 @@ dependencies: readme.should_not contain(%{TODO: Write installation instructions here}) readme.should contain(%{require "example"}) readme.should contain(%{1. Fork it ()}) - readme.should contain(%{[jsmith](https://github.com/jsmith) John Smith - creator, maintainer}) + readme.should contain(%{[John Smith](https://github.com/jsmith) John Smith - creator and maintainer}) end describe_file "example_app/README.md" do |readme| @@ -122,7 +122,7 @@ dependencies: readme.should contain(%{TODO: Write installation instructions here}) readme.should_not contain(%{require "example"}) readme.should contain(%{1. Fork it ()}) - readme.should contain(%{[jsmith](https://github.com/jsmith) John Smith - creator, maintainer}) + readme.should contain(%{[John Smith](https://github.com/jsmith) John Smith - creator and maintainer}) end describe_file "example/shard.yml" do |shard_yml| diff --git a/src/compiler/crystal/tools/init/template/readme.md.ecr b/src/compiler/crystal/tools/init/template/readme.md.ecr index 63a127aa5f0f..58fe6a7e9d4c 100644 --- a/src/compiler/crystal/tools/init/template/readme.md.ecr +++ b/src/compiler/crystal/tools/init/template/readme.md.ecr @@ -40,4 +40,4 @@ TODO: Write development instructions here ## Contributors -- [<%= config.github_name %>](https://github.com/<%= config.github_name %>) <%= config.author %> - creator, maintainer +- [<%= config.author %>](https://github.com/<%= config.github_name %>) - creator and maintainer From 102e18a78c6bad04841e563fdb3669ae094e3898 Mon Sep 17 00:00:00 2001 From: r00ster Date: Mon, 29 Oct 2018 12:19:55 +0100 Subject: [PATCH 2/2] Fix specs --- spec/compiler/crystal/tools/init_spec.cr | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/compiler/crystal/tools/init_spec.cr b/spec/compiler/crystal/tools/init_spec.cr index 299121200aa3..348706a5778a 100644 --- a/spec/compiler/crystal/tools/init_spec.cr +++ b/spec/compiler/crystal/tools/init_spec.cr @@ -104,7 +104,7 @@ dependencies: readme.should_not contain(%{TODO: Write installation instructions here}) readme.should contain(%{require "example"}) readme.should contain(%{1. Fork it ()}) - readme.should contain(%{[John Smith](https://github.com/jsmith) John Smith - creator and maintainer}) + readme.should contain(%{[John Smith](https://github.com/jsmith) - creator and maintainer}) end describe_file "example_app/README.md" do |readme| @@ -122,7 +122,7 @@ dependencies: readme.should contain(%{TODO: Write installation instructions here}) readme.should_not contain(%{require "example"}) readme.should contain(%{1. Fork it ()}) - readme.should contain(%{[John Smith](https://github.com/jsmith) John Smith - creator and maintainer}) + readme.should contain(%{[John Smith](https://github.com/jsmith) - creator and maintainer}) end describe_file "example/shard.yml" do |shard_yml|