Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete reference when unsharing a resource #1275

Open
butonic opened this issue Oct 23, 2020 · 2 comments
Open

delete reference when unsharing a resource #1275

butonic opened this issue Oct 23, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@butonic
Copy link
Contributor

butonic commented Oct 23, 2020

how are we going to clean up a reference when the owner unshares a folder?

AFAICT the gateway usershareprolider will get a RemoveShare request.

  1. we delete the share in the usershareprovider, and
  2. we delete the grant in the storageprovider of the owner.

But we also need to delete the reference of the recipient. how do we do that?

@butonic
Copy link
Contributor Author

butonic commented Oct 23, 2020

we could make the gateway delete references if it encounters invalid ones? so whenever we list the shares and we encounter a not found or permissions error ... we remove the reference? or you we just leave them in and keep ignoring them?

@butonic butonic added the bug Something isn't working label Oct 23, 2020
@ishank011
Copy link
Contributor

Yes, that could be one option. Or we could run a background cron. We need a periodic garbage collection functionality for a lot of cases - public shares, invalid references, expired tokens in OCM. So it'd be good to have a package for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants