Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eosfs: don't rely on systemcall to obtain user unix IDs/GroupIds #964

Closed
labkode opened this issue Jul 10, 2020 · 2 comments
Closed

eosfs: don't rely on systemcall to obtain user unix IDs/GroupIds #964

labkode opened this issue Jul 10, 2020 · 2 comments
Assignees

Comments

@labkode
Copy link
Member

labkode commented Jul 10, 2020

In the EOS filesystem implementation we rely on using systemcalls to obtain the user uid/gid. This implies having local users where reva runs and that sucks:
https://github.com/cs3org/reva/blob/master/pkg/storage/utils/eosfs/eosfs.go#L1219

We should obtain this information directly by calling the UserProviderAPI (through the Gateway).

@butonic
Copy link
Contributor

butonic commented Jul 10, 2020

we could mint the uid and gid into the token. In any case, we need to add uid and gid to the cs3 User: https://cs3org.github.io/cs3apis/#cs3%2fidentity%2fuser%2fv1beta1%2fresources.proto

@labkode
Copy link
Member Author

labkode commented Jul 13, 2020

@butonic that is a nice idea. The uid/gid are quite specific for the EOS filesystem so I think they should still be part of the Opaque part unless there are other fs that will needed and then we can make it first class citizen. Any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants