diff --git a/changelog/unreleased/make-jaeger-agent-usable.md b/changelog/unreleased/make-jaeger-agent-usable.md new file mode 100644 index 0000000000..a5f7d5bb73 --- /dev/null +++ b/changelog/unreleased/make-jaeger-agent-usable.md @@ -0,0 +1,7 @@ +Bugfix: Make Jaeger agent usable + +Previously, you could not use tracing with jaeger agent because the tracing connector is always used instead of the tracing endpoint. + +This PR removes the defaults for collector and tracing endpoint. + +https://github.com/cs3org/reva/pull/1379 diff --git a/cmd/revad/runtime/runtime.go b/cmd/revad/runtime/runtime.go index 77b127b995..5d2a934bee 100644 --- a/cmd/revad/runtime/runtime.go +++ b/cmd/revad/runtime/runtime.go @@ -263,14 +263,6 @@ func setupOpenCensus(conf *coreConf) error { return nil } - if conf.TracingEndpoint == "" { - conf.TracingEndpoint = "localhost:6831" - } - - if conf.TracingCollector == "" { - conf.TracingCollector = "http://localhost:14268/api/traces" - } - if conf.TracingServiceName == "" { conf.TracingServiceName = "revad" }