From 3bba1e74db8583c55582da0bf72374d8a8b893de Mon Sep 17 00:00:00 2001 From: Christian Richter Date: Tue, 26 Sep 2023 14:52:27 +0200 Subject: [PATCH 1/2] Add missing case for "hide" in UpdateShares MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Jörn Friedrich Dreyer Signed-off-by: Christian Richter --- pkg/share/manager/jsoncs3/jsoncs3.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkg/share/manager/jsoncs3/jsoncs3.go b/pkg/share/manager/jsoncs3/jsoncs3.go index 8f35cdecba..5deba084d5 100644 --- a/pkg/share/manager/jsoncs3/jsoncs3.go +++ b/pkg/share/manager/jsoncs3/jsoncs3.go @@ -511,6 +511,8 @@ func (m *Manager) UpdateShare(ctx context.Context, ref *collaboration.ShareRefer toUpdate.Permissions = updated.Permissions case "expiration": toUpdate.Expiration = updated.Expiration + case "hide": + toUpdate.Hide = updated.Hide default: return nil, errtypes.NotSupported("updating " + fieldMask.Paths[i] + " is not supported") } From 276895a23c3dc6e64775ebcfa9eda381bc6003c4 Mon Sep 17 00:00:00 2001 From: Christian Richter Date: Tue, 26 Sep 2023 15:09:25 +0200 Subject: [PATCH 2/2] Add changelog MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Jörn Friedrich Dreyer Signed-off-by: Christian Richter --- changelog/unreleased/fix-missing-case.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 changelog/unreleased/fix-missing-case.md diff --git a/changelog/unreleased/fix-missing-case.md b/changelog/unreleased/fix-missing-case.md new file mode 100644 index 0000000000..d4085af706 --- /dev/null +++ b/changelog/unreleased/fix-missing-case.md @@ -0,0 +1,5 @@ +Bugfix: Fix missing case for "hide" in UpdateShares + +We fixed a bug that caused ocs to throw a 996 on update of permissions. + +https://github.com/cs3org/reva/pull/4217 \ No newline at end of file