From dde826e725f1dcdb726f3680c2b36f82a3152bdf Mon Sep 17 00:00:00 2001 From: Chris Salvato Date: Wed, 6 Jul 2016 13:36:59 -0400 Subject: [PATCH] Remove quality score. Unused and causing bug --- AdWordsUtilities/R/summarize_elog.r | 2 +- BingUtilities/R/summarize_elog.r | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/AdWordsUtilities/R/summarize_elog.r b/AdWordsUtilities/R/summarize_elog.r index 09b525a..1a3d9f4 100644 --- a/AdWordsUtilities/R/summarize_elog.r +++ b/AdWordsUtilities/R/summarize_elog.r @@ -20,7 +20,7 @@ summarize_elog <- function(elog_data_frame, return (summarize(elog_data_frame, cost = sum(cost, na.rm = TRUE), average_position = weighted.mean(average_position,impressions, na.rm=TRUE), - average_quality_score=ifelse(is.null(elog_data_frame$quality_score), NA, mean(quality_score, na.rm=TRUE)) , + #average_quality_score=ifelse(is.null(elog_data_frame$quality_score), NA, mean(quality_score, na.rm=TRUE)) , estimated_available_impressions = sum(impressions/est_search_impression_share, na.rm=TRUE), impressions = sum(impressions, na.rm = TRUE), # imp share is not wholly accurate because of the way the numbers are reported, but close enough. diff --git a/BingUtilities/R/summarize_elog.r b/BingUtilities/R/summarize_elog.r index 1efc133..519b8f3 100644 --- a/BingUtilities/R/summarize_elog.r +++ b/BingUtilities/R/summarize_elog.r @@ -19,7 +19,7 @@ summarize_elog <- function(elog_data_frame, require(dplyr) return (summarize(elog_data_frame, cost = sum(cost, na.rm = TRUE), average_position = weighted.mean(average_position,impressions, na.rm=TRUE), - average_quality_score=mean(quality_score, na.rm=TRUE), + #average_quality_score=mean(quality_score, na.rm=TRUE), impressions = sum(impressions, na.rm = TRUE), #### Can't get impression share info from Bing (at least not in a way that CVS understands...?) #estimated_available_impressions = sum(impressions/est_search_impression_share, na.rm=TRUE),