Skip to content
This repository has been archived by the owner on Apr 16, 2020. It is now read-only.

track private repository support for Visual Studio 2017 #204

Closed
ctaggart opened this issue May 1, 2017 · 29 comments
Closed

track private repository support for Visual Studio 2017 #204

ctaggart opened this issue May 1, 2017 · 29 comments

Comments

@ctaggart
Copy link
Owner

ctaggart commented May 1, 2017

dotnet/roslyn#12759 (comment)

RE: auth - our tentative plan was to handle <not found | unauthorized | forbidden | etc> status codes and allow the user to authenticate and/or use a credential store where the user can somehow associate credentials with a URL. Though we haven't had the chance to get back and prototype this yet.

@ctaggart
Copy link
Owner Author

ctaggart commented May 1, 2017

dotnet/core#598 (comment)

Authentication is planned but not yet supported.

@ctaggart
Copy link
Owner Author

ctaggart commented May 1, 2017

opened dotnet/roslyn#19143

@ctaggart
Copy link
Owner Author

ctaggart commented May 2, 2017

@ctaggart
Copy link
Owner Author

Currently, only 53 votes. We are going to need more votes.

@wes-goulet
Copy link

@ctaggart More votes now :) What is the magic number? Debugging nugets on private feeds is so painful today.

@ctaggart
Copy link
Owner Author

@wes566, I'm not sure. We are at 93 now Let's shoot for 300. I'm hoping the Windows PDB support shipping with Visual Studio 15.3 will unblock Microsoft open source from using it. When adoption of enabling source link increases, more and more will want private repository support too.

@evil-shrike
Copy link

evil-shrike commented Oct 4, 2017

Can you confirm my understanding:
Previously we could index symbols (PDBs) with help of ssindex.cmd script from WinDBG's srvsrv. And that indexed PDBs allow VS to fetch sources during debugging from Git (or other VCS). Git servers with authentication worked fine as VS just executes embedded scripts.
Now if we use portable PDBs then srvsrv won't work and we have to use SourceLink. But VS support for SourceLink will fail to fetch files during debugging if remote git server uses authentication.
Is that correct?

@evil-shrike
Copy link

271 votes now!

Could you share any info for status of private repository support in portable pdbs?

@ctaggart
Copy link
Owner Author

The /embed option is now marked complete!

@ivan-prodanov
Copy link

I guess this would also enable us to pull from VSTS, right?

@ctaggart
Copy link
Owner Author

dotnet/roslyn#19127 (comment)

we have recently bumped up the priority of this work item based on user feedback. It is the next work item on our list that we are going to take on in this space (i.e. it should start in the next week or so). It is too early to share timeline / target VS release at this point. Hope this helps.

@ctaggart
Copy link
Owner Author

ctaggart commented Apr 11, 2018

It was announced on a the Visual Studio roadmap. It should be in an update sometime in Q2.
https://docs.microsoft.com/en-us/visualstudio/productinfo/vs2018-roadmap

@scottt732
Copy link

scottt732 commented Apr 11, 2018

It looks like this is in VS 2017.5 Preview 3. See the UserVoice / release notes in the Debugging section: https://blogs.msdn.microsoft.com/visualstudio/2018/04/09/visual-studio-2017-version-15-7-preview-3/

@jnm2
Copy link
Contributor

jnm2 commented Apr 11, 2018

@scottt732 I think you meant to say VS 2017 Update 7 preview 3, aka 15.7 preview 3?

It certainly seems like 15.7 is the plan! dotnet/designs#37

@ghost
Copy link

ghost commented Apr 17, 2018

@ctaggart will there be something like SourceLink.Create.VSO.Git given that VS 2017 will support SourceLink for repos that require auth

@ctaggart
Copy link
Owner Author

ctaggart commented Apr 17, 2018

@kzeronik For private repositories, you can simply set the SourceLinkUrl manually with the current version of SourceLink, version 2. For version 3, there will be a SourceLink.VSO.Git provider. See #326 for some more details.

@ghost
Copy link

ghost commented Apr 17, 2018

Thanks @ctaggart - something like this then

dotnet build /p:SourceLinkCreate=true /p:SourceLinkUrl <url to my vsts repo> /v:n

@ctaggart
Copy link
Owner Author

@kzeronik, Yes, or you can set the props in the msbuild build files, such as Directory.Build.props. You can search GitHub for examples:
https://github.com/search?l=XML&q=SourceLinkUrl&type=Code

@Tadimsky
Copy link

@ctaggart
I've tried setting SourceLinkUrl to the VSTS API url and it all seems ok:

dotnet sourcelink print-json C:\Users\joschm.nuget\packages\microsoft.intentional.services.utilities.authentication\2.0.363-beta\lib\netstandard2.0\Microsoft.Intentional.Services.Utilities.Authentication.pdb

{"documents":{"D:\a\1\s\*":"https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=*&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit"}}

Here is the full url:

8a0e49f86db1d18ee1b278912c30a33eaf57f862 sha1 csharp D:\a\1\s\Authentication\AuthorizationExtensions.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/AuthorizationExtensions.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
47c0d107a700ca67afeaa2a7d26182962ba28813 sha1 csharp D:\a\1\s\Authentication\ClaimsPrincipalExtensions.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/ClaimsPrincipalExtensions.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
67a25590392d1836d4e2b3ac2164ca2e4073d77e sha1 csharp D:\a\1\s\Authentication\Users\AadUser.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/Users/AadUser.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
ab60f98f3be8350f6f04487b67c83b7aa72a81db sha1 csharp D:\a\1\s\Authentication\Users\AadUserCreator.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/Users/AadUserCreator.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
5b77be34fb540f647719a79760ecb36be7708784 sha1 csharp D:\a\1\s\Authentication\Users\MsaUser.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/Users/MsaUser.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
54149ba92e73dbb013af62f2ae15272bc26e4e19 sha1 csharp D:\a\1\s\Authentication\Users\MsaUserCreator.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/Users/MsaUserCreator.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
aaa8ed75d54bd739e32b823e17d46cb0afbadfe3 sha1 csharp D:\a\1\s\Authentication\Users\UnauthenticatedUser.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/Users/UnauthenticatedUser.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
bb3bbf2897a1fefc81a50c163d8e6e989e8ec0dd sha1 csharp D:\a\1\s\Authentication\Users\UnknownUser.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/Users/UnknownUser.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
8620f884608968491c6fc283f36bdfcb45339e61 sha1 csharp D:\a\1\s\Authentication\Users\User.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/Users/User.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
86afaa21d83079ec984b21984e8cf5b6c15d948d sha1 csharp D:\a\1\s\Authentication\Users\UserExtensions.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/Users/UserExtensions.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
bcb28f2971f0d1a26cd3138d4bb2a7bd203f5f0e sha1 csharp D:\a\1\s\Authentication\Users\UserFactory.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/Users/UserFactory.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
fbb930b7ed6b5b7d1e53d6e6d2e9e847ce92c0bb sha1 csharp D:\a\1\s\Authentication\Policies\AadAdminRequirement.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/Policies/AadAdminRequirement.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
eb0a8c7ae90ef49c320d9b2f8d8062cb2f1a6ebe sha1 csharp D:\a\1\s\Authentication\Policies\AadGroupAuthorizationHandler.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/Policies/AadGroupAuthorizationHandler.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
c5a52f96d5e87d4d63631f823bad540c5d99ea80 sha1 csharp D:\a\1\s\Authentication\Policies\AadGroupOptions.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/Policies/AadGroupOptions.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
c8872e06700097de62f3eb5b3938c4915a056805 sha1 csharp D:\a\1\s\Authentication\Policies\AadGroupRequirement.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/Policies/AadGroupRequirement.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
328ae32cf405cbc501ca291b15284fa38b3246eb sha1 csharp D:\a\1\s\Authentication\Msa\MsaAuthenticationExtensions.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/Msa/MsaAuthenticationExtensions.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
f8c7ac92aae0168c921f8b079bd3913a79d9ff23 sha1 csharp D:\a\1\s\Authentication\Msa\MsaAuthenticationHandler.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/Msa/MsaAuthenticationHandler.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
efeaa66d934b796e7e6b50016d9916576e176ecf sha1 csharp D:\a\1\s\Authentication\Msa\MsaAuthenticationOptions.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/Msa/MsaAuthenticationOptions.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
065f39465fd7225f3a35e72ecc3dd0e7b260a974 sha1 csharp D:\a\1\s\Authentication\Msa\MicrosoftAccount\MsaError.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/Msa/MicrosoftAccount/MsaError.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
8b9bec59da7c84ded4d86551c131e7eb6981b92b sha1 csharp D:\a\1\s\Authentication\Msa\MicrosoftAccount\MsaIdentity.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/Msa/MicrosoftAccount/MsaIdentity.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
465287840502da59757dd8c17269b71f7c383a30 sha1 csharp D:\a\1\s\Authentication\Msa\MicrosoftAccount\MsaIdentityInformation.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/Msa/MicrosoftAccount/MsaIdentityInformation.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
a28ac606542a54252566274c49bc72a099ae00df sha1 csharp D:\a\1\s\Authentication\Msa\MicrosoftAccount\MsaSecurityToken.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/Msa/MicrosoftAccount/MsaSecurityToken.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
9f23a3102e52b4f681ecbb370aa80bc0b187f9dc sha1 csharp D:\a\1\s\Authentication\Msa\MicrosoftAccount\MsaSecurityTokenValidator.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/Msa/MicrosoftAccount/MsaSecurityTokenValidator.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
37c98ab979cc5547e1a70f53bc382c1773fce2b2 sha1 csharp D:\a\1\s\Authentication\Msa\MicrosoftAccount\Events\AuthenticationFailedContext.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/Msa/MicrosoftAccount/Events/AuthenticationFailedContext.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
1ddf193d9b9d3f4c4c81c06c3573662cb8084928 sha1 csharp D:\a\1\s\Authentication\Msa\MicrosoftAccount\Events\MessageReceivedContext.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/Msa/MicrosoftAccount/Events/MessageReceivedContext.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
051a17943d9db07d7adb1be3aa161a778a0e7e17 sha1 csharp D:\a\1\s\Authentication\Msa\MicrosoftAccount\Events\TokenValidatedContext.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/Msa/MicrosoftAccount/Events/TokenValidatedContext.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
b6061d6c25dafac2783aba18ee4e2836fe965242 sha1 csharp D:\a\1\s\Authentication\Delegate\AadDelegateProvider.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/Delegate/AadDelegateProvider.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
fcc8cf4222d879000e37edf94ac7556d7b86bc5b sha1 csharp D:\a\1\s\Authentication\ClientCertificate\ClientCertificateAuthOptions.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/ClientCertificate/ClientCertificateAuthOptions.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
fad40240f3e3e99621316a7ecfe85fb707621613 sha1 csharp D:\a\1\s\Authentication\ClientCertificate\ClientCertificateExtensions.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/ClientCertificate/ClientCertificateExtensions.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
8cf60f96fa5415c2a9dcf9066f2196c8cf62cbfd sha1 csharp D:\a\1\s\Authentication\ClientCertificate\ClientCertificateHandler.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/ClientCertificate/ClientCertificateHandler.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
adcd7af640781f557d19774e40c99bbce4787b2b sha1 csharp D:\a\1\s\Authentication\ClientCertificate\Identity\ClientCertificateAadIdentity.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/ClientCertificate/Identity/ClientCertificateAadIdentity.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
7b831efe19f828cfbc4df653e9ec8d635ff3c250 sha1 csharp D:\a\1\s\Authentication\ClientCertificate\Identity\ClientCertificateIdentity.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/ClientCertificate/Identity/ClientCertificateIdentity.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
f08d518cf8b228e5dc8d090e44d1fff760b50117 sha1 csharp D:\a\1\s\Authentication\ClientCertificate\Identity\ClientCertificateMsaIdentity.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/ClientCertificate/Identity/ClientCertificateMsaIdentity.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
ee8ea8abf9c74f9a763ce0b3fbfc6ca7f19ad8bd sha1 csharp D:\a\1\s\Authentication\Certificates\CertificateUtilities.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/Certificates/CertificateUtilities.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
2a0cbc544783d02cb5f96ebc85050683135a21ee sha1 csharp D:\a\1\s\Authentication\Aad\AadOptions.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/Aad/AadOptions.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit
a34e56a5f6a1a6bafab7e23b44454ffe7b5e6a35 sha1 csharp D:\a\1\s\Authentication\Aad\AzureActiveDirectoryExtensions.cs
https://intentional.visualstudio.com/intent/_apis/git/repositories/93a9259d-805c-44ab-8fd2-13d7b7052e1e/items?path=Authentication/Aad/AzureActiveDirectoryExtensions.cs&versionDescriptor.version=da102b39116d57c2ace482d18f1e328d2613dcd1&versionDescriptor.versionType=commit

However, it doesn't seem to load source in VS - I'm running 15.7 Preview 4.0
Any ideas what could be going wrong?

@ctaggart
Copy link
Owner Author

@Tadimsky, since you are using VSTS, I'd give SourceLink v3 a shot. You can find details here:
https://github.com/dotnet/sourcelink#using-sourcelink

@Tadimsky
Copy link

Great! I didn't know it was out yet.
I'll try that.

@ctaggart
Copy link
Owner Author

It is great that Visual Studio 15.7 has support for private auth to VSTS and GitHub https://goo.gl/iNAvgW. I just created a new user voice for generic auth support so that we can use GitHub Enterprise, GitLab, and other sources. Please vote for it https://goo.gl/UzD1iS.

I also requested the same thing from JetBrains Rider. If they added support, I could debug into source code on a Linux machine. https://youtrack.jetbrains.com/issue/RIDER-16260

@ctaggart
Copy link
Owner Author

ctaggart commented May 23, 2018

Great! I didn't know it was out yet.

Well, those pieces are in beta. An official v3 isn't out yet, but those are the core components and should be usable. When I figure out what to wrap or collect everything, it will be in issue #305.

@evil-shrike
Copy link

@ctaggart we also created https://developercommunity.visualstudio.com/content/problem/257347/unnecessary-restrictions-on-authenticated-source-l.html?childToView=257351
(the support for auth in VS 15.7 is surprisingly limited to two services for unclear reason)

@ctaggart ctaggart changed the title track private repository support track private repository support for Visual Studio 2017 Jun 15, 2018
@ctaggart
Copy link
Owner Author

I'm not sure if updates to private repository support will be in Visual Studio 2017 15.8 or not. I don't see any mentions in the release notes
https://docs.microsoft.com/en-us/visualstudio/releasenotes/vs2017-preview-relnotes

@ctaggart
Copy link
Owner Author

Looks like it is going to be supported in 15.8 via the support for Git Credential Manager

@ctaggart
Copy link
Owner Author

Get it while it is hot! 15.8 preview 4, which came out on the 10th, has private repo support! I'm downloading now.

The new Tools -> Options -> Debugging checkbox is available in 15.8 Preview 4 available here: https://visualstudio.microsoft.com/vs/preview/
Enabling "Fall back to Git Credential Manager authentication for all Source Link requests" will allow Source Link to bypass the domain whitelist and attempt to gather credentials from GCM for all Source Link requests.
https://developercommunity.visualstudio.com/content/problem/257347/unnecessary-restrictions-on-authenticated-source-l.html

@ctaggart
Copy link
Owner Author

Here is the option that provides private repository support in VS 15.8:
image

@ctaggart
Copy link
Owner Author

It is working for me and my team with GitHub Enterprise.
dotnet/sourcelink#148 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants