PERF: speed up the adjustment of SNR #36
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SNR adjustment is currently very slow (13 seconds) when the number of noise sources is 500 (see detailed reports below):
_combine_stcs
. In this PR,_combine_sources_into_stc
is reworked to combine all sources at once instead of adding them one by one._get_sensor_space_variance
(1 for all noise + 5 for alpha sources). While the calculation of covariance should be the correct approach to account for correlations between sources, in practice it might be computationally easier to actually project the data to sensor space and average the squared values to get mean variance. This strategy is also implemented in this PR.Current version on master:
The same simulation after the optimization: