ENH: allow setting the std parameter using SourceEstimate #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astudenova
reviewed
Feb 6, 2025
| # vertices of the patch | ||
| if isinstance(stds, mne.SourceEstimate): | ||
| std = _get_param_from_stc(stds, [(src_idx, vertno)]) | ||
| patch_stds.append(std.mean()) |
There was a problem hiding this comment.
I have a misunderstanding. I thought we are populating std from the center of the patch to all other points. Could you clarify this and also under which circumstances the std.mean() could be applied?
|
|
||
| def prepare_source_estimate(data, vertices): | ||
| vertices = [np.array(el) for el in vertices] | ||
| return mne.SourceEstimate(np.array(data), vertices, tmin=0, tstep=0.01) |
There was a problem hiding this comment.
Maybe add subject="fsaverage"
| @@ -107,3 +107,8 @@ def prepare_point_source(name, src_idx=0, vertno=0, n_samples=100): | |||
| def prepare_patch_source(name, src_idx=0, vertno=[0, 1], n_samples=100): | |||
| waveform = np.ones((n_samples,)) | |||
| return PatchSource(name, src_idx, vertno, waveform) | |||
|
|
|||
|
|
|||
| def prepare_source_estimate(data, vertices): | |||
There was a problem hiding this comment.
I think it's a useful function. You use the same in dummy. Maybe, it could go to utils.py?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.