-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: allow setting the std parameter using SourceEstimate #67
Open
ctrltz
wants to merge
26
commits into
master
Choose a base branch
from
ctrltz/std-as-stc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
1726ba1
Divide by std instead of norm when normalizing
ctrltz e7b7fde
Replace scaling factor with SourceSimulator.base_amplitude
ctrltz e6f0013
TEST: fix tests after introducing base amplitude
ctrltz 8e87b37
Introduce standard deviation of the waveform
ctrltz 3acb544
Add std to the public API (tests are broken)
ctrltz ee3e08b
TEST: tests for check_numeric_array
ctrltz f7feaa3
TEST: fix all other tests
ctrltz 1a0d822
Docstring, base_amplitude -> base_std
ctrltz 01d87ee
TEST: test the std-based scaling
ctrltz cf79cdc
DOC: docstrings
ctrltz fd053a2
MAINT: changelog entry
ctrltz 919d5b4
DOC: docstring
ctrltz 447e41c
ENH: allow setting std using a SourceEstimate
ctrltz 0162bb0
Fix minor errors
ctrltz 0436289
Merge branch 'master' into ctrltz/std-as-stc
ctrltz e7bcdeb
Merge branch 'master' into ctrltz/std-as-stc
ctrltz 53aad08
Fix std check for patch sources
ctrltz 7bc2d43
TEST: tests for check_stc_as_param
ctrltz 88cb9b5
TEST: tests for _get_param_from_stc
ctrltz 7da0407
Slowly getting rid of relative imports
ctrltz 79dec97
TEST: fix all tests
ctrltz 44eb37c
Remove strict=True from zips - not supported in py3.9
ctrltz b4891b7
DOC: describe the new option in the docstring
ctrltz fa6de8f
MAINT: changelog entry
ctrltz 7c449de
Merge branch 'master' into ctrltz/std-as-stc
ctrltz 7c8e084
Fix the case of manually provided patch vertices
ctrltz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a misunderstanding. I thought we are populating std from the center of the patch to all other points. Could you clarify this and also under which circumstances the std.mean() could be applied?