ENH: lower-level functions for the adjustment of SNR #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrltz
requested changes
Aug 10, 2024
ctrltz
reviewed
Aug 12, 2024
tests/test_snr.py
Outdated
| vertices = [[0, 1], [0, 1]] | ||
| stc = prepare_stc(vertices) | ||
| variance = get_sensor_space_variance(stc, fwd, filter=False) | ||
| assert variance >= 0, "Variance should be non-negative" |
There was a problem hiding this comment.
I think that this check is not sufficient - all values (stc and leadfield) are squared so the result should be positive regardless of which vertices are used. Please define the leadfield values yourself and calculate the expected variance with all sources and a subset of sources. Feel free to reduce the dimensionality to make the calculations easier (2x2 leadfield and 1-source stc should already be sufficient to check that the second source does not play a role).
There was a problem hiding this comment.
MEG/EEG aspect is probably not so important here, both are numbers in the end
ctrltz
reviewed
Aug 12, 2024
ctrltz
reviewed
Aug 12, 2024
ctrltz
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For review