Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spring] Add @CucumberContextConfiguration annotation #1911

Merged
merged 11 commits into from
Mar 19, 2020

Conversation

rasklaad
Copy link

@rasklaad rasklaad commented Mar 4, 2020

Summary

To make Cucumber aware of your test configuration you can annotate a
configuration class with @CucumberContextConfiguration and with one of the
following annotations: @ContextConfiguration, @ContextHierarchy or
@BootstrapWith. If you are using SpringBoot, you can annotate configuration
class with @SpringBootTest(classes = TestConfig.class).

Details

  • Spring backend minimum implementation
  • Spring backend tests
  • Docs/javadocs

Motivation and Context

Fixes: #1896

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@coveralls
Copy link

coveralls commented Mar 4, 2020

Coverage Status

Coverage increased (+0.03%) to 85.975% when pulling bc29621 on spring-without-dummy-method into 1648fb9 on master.

@mpkorstanje
Copy link
Contributor

Don't worry about revapi failing the build right now. It's a semantic version checker. You can ignore it, I'll adjust the version numbers.

@rasklaad rasklaad marked this pull request as ready for review March 19, 2020 16:07
Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Could you also update spring/README.md to include this information?

@mpkorstanje mpkorstanje changed the title Cucumber spring without dummy method [Spring] Add @CucumberContextConfiguration annotation Mar 19, 2020
@mpkorstanje mpkorstanje merged commit 07bcf07 into master Mar 19, 2020
@mpkorstanje mpkorstanje deleted the spring-without-dummy-method branch March 19, 2020 19:24
@mpkorstanje
Copy link
Contributor

And we're done. Thanks you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the neeed for the dummy method when using cucumber-spring
3 participants