Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Emit step hook messages #2093

Merged
merged 2 commits into from
Aug 20, 2020
Merged

[Core] Emit step hook messages #2093

merged 2 commits into from
Aug 20, 2020

Conversation

grasshopper7
Copy link
Contributor

Is your pull request related to a problem? Please describe.
The beforestep and afterstep message details were not displayed in ndjson report.

A link to an issue or a clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Refer to #2058 (comment)

Describe the solution you have implemented
A clear and concise description of what happens.

Additional context
Add any other context or screenshots about the pull request here.

@coveralls
Copy link

coveralls commented Aug 17, 2020

Coverage Status

Coverage increased (+0.003%) to 86.182% when pulling fe0cb3f on grasshopper7:main into fa90854 on cucumber:main.

@mpkorstanje mpkorstanje changed the title Emit beforestep and afterstep hook messages [Core] Emit step hook messages Aug 20, 2020
@mpkorstanje mpkorstanje merged commit e6a9b58 into cucumber:main Aug 20, 2020
@bischoffdev
Copy link
Contributor

Hello all 😄
Do you have a release date for this yet?

@mpkorstanje
Copy link
Contributor

That would be last Wednesday. If you click the link to the merge commit it will show you the commit details which includes a list of tags for the versions this commit is in.

@bischoffdev
Copy link
Contributor

Ah ok, that's why it didn't show up in my tests. I must have updated to 6.5.1 just before 6.6.0 was released 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants