Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XStreamConverters auto-registration is broken #1283

Closed
ddemin opened this issue Nov 26, 2017 · 1 comment
Closed

XStreamConverters auto-registration is broken #1283

ddemin opened this issue Nov 26, 2017 · 1 comment

Comments

@ddemin
Copy link
Contributor

ddemin commented Nov 26, 2017

Summary

At now annotation @XStreamConverters doesn't have any effect, because Runtime class was broken. Line with issue:

glue = optionalGlue == null ? new RuntimeGlue(new LocalizedXStreams(classLoader)) : optionalGlue;

Expected Behavior

When I use @XStreamConverters annotation with @CucumberOptions (for class annotated with JUnit Cucumber runner as example)
Then I can see, that my converters became registered

Current Behavior

When I use @XStreamConverters annotation with @CucumberOptions (for class annotated with JUnit Cucumber runner as example)
Then I don't see, that my converters became registered

Possible Solution

Restore calling of RuntimeGlue constructor with 'new LocalizedXStreams(classLoader, runtimeOptions.getConverters())'
at this line:

glue = optionalGlue == null ? new RuntimeGlue(new LocalizedXStreams(classLoader)) : optionalGlue;

@lock
Copy link

lock bot commented Nov 30, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant