Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Fix test teardown on Windows #2701

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Mar 9, 2023

πŸ€” What's changed?

Fixes #2700

🏷️ What kind of change is this?

  • πŸ› Bug fix (non-breaking change which fixes a defect)

@mpkorstanje mpkorstanje force-pushed the fix-tests-on-windows branch 2 times, most recently from 8ea1d66 to a96cbdf Compare March 9, 2023 16:47
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #2701 (fa80d37) into main (7d90abd) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2701   +/-   ##
=========================================
  Coverage     84.68%   84.68%           
  Complexity     2682     2682           
=========================================
  Files           322      322           
  Lines          9449     9449           
  Branches        899      899           
=========================================
  Hits           8002     8002           
  Misses         1120     1120           
  Partials        327      327           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mpkorstanje mpkorstanje force-pushed the fix-tests-on-windows branch 7 times, most recently from cc19f53 to e596c99 Compare March 9, 2023 18:10
@mpkorstanje mpkorstanje force-pushed the fix-tests-on-windows branch from e596c99 to fa80d37 Compare March 9, 2023 18:19
@mpkorstanje mpkorstanje marked this pull request as ready for review March 9, 2023 19:42
@mpkorstanje mpkorstanje merged commit f7043fc into main Mar 9, 2023
@mpkorstanje mpkorstanje deleted the fix-tests-on-windows branch March 9, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit test PluginFactoryTest fails on Windows due to incorrect teardown
1 participant