internal/core: concreteness errors not reported when conflict errors are present in other values

[verdverm]

What version of CUE are you using (cue version)?

0.4.0

What did you do?

cue eval -c foo.cue
cue vet -c foo.cue

-- foo.cue --
s: "hello"
s: "world"      // conflicting values "hello" and "world"

A: foo: "bar"
a: A.goo        // undefined field

b: int          // incomplete field

m: [1,2]
v: m[2]         // index out of range

I expected all errors for fields which do not interact. Instead I saw a series of errors shown depending on what other errors were found prior.

• conflicting values
• index out of range
• incomplete value

What did you expect to see?

s: conflicting values "world" and "hello":
    ./errors.cue:1:4
    ./errors.cue:2:4
a: undefined field: goo:
    ./errors.cue:5:6
b: incomplete value int
    ./errors.cue:7:4
v: index out of range [2] with length 2:
    ./errors.cue:10:6

What did you see instead?

s: conflicting values "world" and "hello":
    ./errors.cue:1:4
    ./errors.cue:2:4

if s is not present

v: index out of range [2] with length 2:
    ./errors.cue:10:6

if both s and v are not present

b: incomplete value int         // missing line information here
a: undefined field: goo:
    ./errors.cue:5:6

Errors are not in the order they appear. Having them in the same order as they appear in the file would be nice. Probably a separate issue.

[myitcv]

Passing comment: we discussed the different types/categories of errors a good deal whilst considering #822.

[myitcv]

See also the discussion in #1998.

cc @edouard-lopez

[jpluscplusm]

I believe this issue is also present when list.UniqueItems is used to check a list of structs containing duplicate entries alongside a list of simple values that also fails validation.

This is a recent change, using this version of cue:

cue version v0.12.0-alpha.1.0.20250103115825-74a0c9d01e05

go version go1.23.0
      -buildmode exe
       -compiler gc
  DefaultGODEBUG asynctimerchan=1,gotypesalias=0,httpservecontentkeepheaders=1,tls3des=1,tlskyber=0,x509keypairleaf=0,x509negativeserial=1
     CGO_ENABLED 1
          GOARCH amd64
            GOOS linux
         GOAMD64 v1
cue.lang.version v0.12.0

Testscript:

! exec cue vet -c file.cue
cmp stderr out
-- file.cue --
import "list"

a: list.UniqueItems & [
	0, 1, 2, 0,
]
b: list.UniqueItems & [
	{foo: 1},
	{foo: 1},
]
-- out --
a: invalid value [0,1,2,0] (does not satisfy list.UniqueItems): equal value (0) at position 0 and 3:
    ./file.cue:3:4
b: invalid value [{foo:1},{foo:1}] (does not satisfy list.UniqueItems):
    ./file.cue:6:4

Expected: passing script.
Actual:

> ! exec cue vet -c file.cue
[stderr]
a: invalid value [0,1,2,0] (does not satisfy list.UniqueItems): equal value (0) at position 0 and 3:
    ./file.cue:3:4
[exit status 1]
> cmp stderr out
diff stderr out
--- stderr
+++ out
@@ -1,2 +1,4 @@
 a: invalid value [0,1,2,0] (does not satisfy list.UniqueItems): equal value (0) at position 0 and 3:
     ./file.cue:3:4
+b: invalid value [{foo:1},{foo:1}] (does not satisfy list.UniqueItems):
+    ./file.cue:6:4

FAIL: /tmp/testscript254369837/list.txtar/script.txtar:2: stderr and out differ