Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub-millisecond ID test failed once #90

Open
cuibonobo opened this issue Dec 2, 2024 · 0 comments
Open

Sub-millisecond ID test failed once #90

cuibonobo opened this issue Dec 2, 2024 · 0 comments

Comments

@cuibonobo
Copy link
Owner

I thought I had addressed all of the bugs in the sub-millisecond ID generation, but it seems like there is still a rare/subtle one still in there. I didn't take a screenshot but what I observed when the failure happened is that the timeStampSet appeared to have two items (there should have been only 1) where the second item was the same as the first but with an appended zero (0).

I'm not sure how it overflowed... Might need to run the sub-millisecond tests a bajillion times to see what the actual error was.

Also, the test for detecting that an overflow happened is not well designed: expect(e instanceof Error).toBe(true) is not specific enough to determine which error was thrown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant