Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read only display of descriptions differ from website and from edit view #1561

Open
troughc opened this issue Feb 5, 2025 · 5 comments
Open
Assignees
Labels
bug Something isn't working
Milestone

Comments

@troughc
Copy link
Contributor

troughc commented Feb 5, 2025

The read only display seems to look a bit different than what appears on a website (tout culture for example) as well as how it is displayed in the Edit view.

Example 1.

The Edit view and Website match for this organization from Tout Culture. The description appears differently on the read only page (extra spaces between paragraphs as well as not displaying the use of bold on "Mission").
This means that this issue is not a priority (we can create a separate issue). :)
Website link:
https://toutculture.ca/organismes-detail/?organize=6451675de19f7200646d24da
CMS link:
https://cms.footlight.io/dashboard/6308ef4a7f771f00431d939a/organizations/6451675de19f7200646d24da

Example 2

In Artbi I creates a person, org, and event. These do not appear on websites so we cannot compare. However, you can see the display difference between Edit views and Read-only views.

example Event: Read-only doesn't display a Heading or spaces between paras the same as in Edit view

example Organizaton: Headings and spacing between paragraphs

example Person: paragraph spacing.

@troughc
Copy link
Contributor Author

troughc commented Feb 5, 2025

@AbhishekPAnil here is the issue I created. if you would like to add anything (such as the css comment, please edit the above description. I will leave it assigned to me until we are ready to put it into a future sprint. Thank you.

@troughc troughc self-assigned this Feb 5, 2025
@troughc troughc added the bug Something isn't working label Feb 5, 2025
@sahalali sahalali added this to the CC 2025.2 milestone Feb 24, 2025
@AbhishekPAnil AbhishekPAnil linked a pull request Mar 10, 2025 that will close this issue
@AbhishekPAnil
Copy link
Contributor

AbhishekPAnil commented Mar 10, 2025

Currently the issue with the inconsistency in spacing in the read only and edit view is a display issue which is dealt in 114

Here are my findings for this issue :

The first image shows the description on the Tout Culture website, where the <p> tag has no margin. This is the correct way to display the description since no additional margin styles are being applied from the CMS editor.

Image

The second image is from Signe Laval, where a margin-bottom style is applied to the <p> tag. This margin comes from the website's styles.

Image

If these styles are globally applied, we may not be able to fix the issue on our end.

@troughc
Copy link
Contributor Author

troughc commented Mar 10, 2025

Thanks @AbhishekPAnil; so you mean that Signe Laval problem may not be able to be fixed.

Here is another example from Tout Culture. Can you tell me what is happening? What is causing this?
See:
https://toutculture.ca/evenement/des-etres-des-lieux-et-des-choses-de-michael-minor-67aa13655fd5ea006425142e/
https://cms.footlight.io/dashboard/6308ef4a7f771f00431d939a/events/add-event/67aa13655fd5ea006425142e

What is strange is that it is just the spacing between paragraph one and paragraph two which seems to be inconsistent. The rest looks the same:

Image Image

@AbhishekPAnil
Copy link
Contributor

AbhishekPAnil commented Mar 10, 2025

Thanks @AbhishekPAnil; so you mean that Signe Laval problem may not be able to be fixed.

Yes, the global margin styles applied to different tags can vary across different websites.Hence its not in our control.

Can you tell me what is happening? What is causing this?

This is the french description html we are providing in the open api for the event thats mentioned :

<p><strong>Vernissage: samedi le 1 mars de 13h à 16h</strong></p><p>&nbsp;</p><p>La Galerie Old Chelsea a le plaisir d'accueillir une exposition de Michael Minor, un peintre d'Ottawa de formation classique qui a étudié à la Heatherley School of Fine Art de Londres, en Angleterre, et à la Florence Academy of Art de Florence, en Italie. Minor s'inspire des compétences techniques et des compositions traditionnelles des maîtres du passé et des grands peintres figuratifs d'aujourd'hui. Il parle de ses peintures comme ayant été construites grâce aux connaissances des peintres traditionnels telles qu'elles ont été transmises au cours des millénaires. Minor souhaite raconter des histoires intemporelles avec ses peintures et les intégrer à l'ensemble des œuvres collectives.&nbsp;</p><p><br></p><p>« Le réalisme est mal compris et a continué à l'être durant la plus grande partie du vingtième siècle, comme un art d'imitation », mais comme le dit Minor, dans les bonnes mains, il peut être une “puissante force créatrice”.&nbsp;Lorsque les gens regardent ses peintures, Michael Minor veut qu'ils ressentent des choses qui ne peuvent être exprimées par des mots.</p><p><br></p><p>« En tant qu'ancien soldat, Michael nous raconte : « J'ai été témoin de la majesté et de la méchanceté de l'humanité. Mais je suis toujours fasciné par l'animal humain et son esprit obstinément constant, ses conditions émotionnelles intemporelles et ses environnements variés. »</p><p>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</p><p>Michael peut parler du meilleur et du pire de la nature humaine, mais son art est axé sur la beauté.&nbsp;Il faut absolument voir ces magnifiques peintures.</p><p class=\"ql-align-center\"><br></p><p><span style=\"color: rgb(34, 34, 34);\">La Galerie Old Chelsea, qui présente des artistes locaux, est située dans les magnifiques collines de la Gatineau,</span></p><p><span style=\"color: rgb(34, 34, 34);\">au-dessus du restaurant primé Les Fougères, situé au 783, route 105, Chelsea (Québec) J9B1P1.</span></p><p><br></p><p><strong>Galerie Old Chelsea. 783 route 105, Chelsea, Québec, J9B 1P1</strong></p><p><a href=\"http://www.galerieoldchelsea.ca\" rel=\"noopener noreferrer\" target=\"_blank\" style=\"color: blue;\"><strong>www.galerieoldchelsea.ca</strong></a> &amp; Facebook (Galerie Old Chelsea au 783 route 105 et non sur le chemin Scott))</p><p>Pour de plus amples renseignements: Anne Swiderski 819 827 8504.&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</p>

and below is the description rendered in tout culture website

Image

You can see that there is a different in the paragraph tag after the first paragraph.
<p>&nbsp;</p> This is missing in their site.I checked the open api and we are providing this but somehow it is stripped off.

Below is a manually edited version of the html of how it would have been shown if the tag was there ,just for reference :

Image

cc @troughc

@troughc
Copy link
Contributor Author

troughc commented Mar 10, 2025

@saumier I think we may need to follow up with our client's web teams to fix the above issue. Let's discuss.

@troughc troughc assigned saumier and unassigned AbhishekPAnil Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants