Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle-featured API call from CMS always has the false param #1586

Open
dev-aravind opened this issue Feb 21, 2025 · 4 comments · Fixed by #1590
Open

Toggle-featured API call from CMS always has the false param #1586

dev-aravind opened this issue Feb 21, 2025 · 4 comments · Fixed by #1590
Assignees
Labels
bug Something isn't working
Milestone

Comments

@dev-aravind
Copy link
Contributor

The toggle-featured API call from the CMS app is always setting the param as false, even when we want to set isFeatured as true.

This was working fine in the CMS because of a bug in the actual toggle-api that made these bugs cancel out. The bug in footlight-api has been resolved by @SuhailAliyar as part of https://github.com/culturecreates/footlight-calendar-api/issues/1207. The CMS bug should also be fixed when the above fix gets released.

cc @AbhishekPAnil

@dev-aravind dev-aravind added the to be scheduled Work has been estimated, now it needs a priority and milstone label Feb 21, 2025
@sahalali sahalali removed the to be scheduled Work has been estimated, now it needs a priority and milstone label Feb 21, 2025
@troughc troughc added the bug Something isn't working label Feb 21, 2025
@troughc
Copy link
Contributor

troughc commented Feb 21, 2025

@sahalali let's discuss Monday.

@sahalali sahalali assigned AbhishekPAnil and unassigned troughc and sahalali Feb 24, 2025
@AbhishekPAnil AbhishekPAnil linked a pull request Feb 24, 2025 that will close this issue
@AbhishekPAnil
Copy link
Contributor

AbhishekPAnil commented Feb 24, 2025

@dev-aravind
Copy link
Contributor Author

dev-aravind commented Feb 24, 2025

@kmdvs Hi Kim, the tests seem to be inconsistent in the taxonomy creation part. Cypress clicks on [data-cy="taxonomy-concept-cell-fr"] and expects [data-cy="taxonomy-concept-cell-fr"] textarea, but the text area only loads in if you click precisely on the "Concept French" text, resulting in the inconsistency. Can you look into this?

some logs that I found:

        cy:command (K): [2025-02-24T12:28:15.321Z] [cy:command] get	[data-cy="taxonomy-concept-cell-fr"] div
        cy:command (K): [2025-02-24T12:28:15.321Z] [cy:command] click	{force: true}
        cy:command (X): [2025-02-24T12:28:15.321Z] [cy:command] get	[data-cy="taxonomy-concept-cell-fr"] textarea
        cy:command (X): [2025-02-24T12:28:15.321Z] [cy:command] assert	expected **[data-cy="taxonomy-concept-cell-fr"] textarea** to exist in the DOM
                        Actual: 	"[data-cy=\"taxonomy-concept-cell-fr\"] textarea"
                        Expected: 	"[data-cy=\"taxonomy-concept-cell-fr\"] textarea"
        cy:command (K): [2025-02-24T12:28:15.321Z] [cy:command] get	body

@troughc troughc added this to the CC 2025.2 milestone Mar 4, 2025
@kmdvs
Copy link
Collaborator

kmdvs commented Mar 10, 2025

@dev-aravind I verified and tested the code more than 100 iterations, in fr and en... There was no error. This seems thus a pretty rare occurrence. If it surfaces back I can revisit it, but right now I'd close that one.

@AbhishekPAnil AbhishekPAnil assigned troughc and unassigned kmdvs Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants