-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggle-featured API call from CMS always has the false param #1586
Comments
@sahalali let's discuss Monday. |
https://github.com/culturecreates/footlight-app/actions/runs/13492561531/job/37701955339 |
@kmdvs Hi Kim, the tests seem to be inconsistent in the taxonomy creation part. Cypress clicks on [data-cy="taxonomy-concept-cell-fr"] and expects [data-cy="taxonomy-concept-cell-fr"] textarea, but the text area only loads in if you click precisely on the "Concept French" text, resulting in the inconsistency. Can you look into this? some logs that I found:
|
@dev-aravind I verified and tested the code more than 100 iterations, in fr and en... There was no error. This seems thus a pretty rare occurrence. If it surfaces back I can revisit it, but right now I'd close that one. |
The toggle-featured API call from the CMS app is always setting the param as false, even when we want to set isFeatured as true.
This was working fine in the CMS because of a bug in the actual toggle-api that made these bugs cancel out. The bug in footlight-api has been resolved by @SuhailAliyar as part of https://github.com/culturecreates/footlight-calendar-api/issues/1207. The CMS bug should also be fixed when the above fix gets released.
cc @AbhishekPAnil
The text was updated successfully, but these errors were encountered: