Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lupa and aioredis optional dependencies #15

Closed
cunla opened this issue May 24, 2022 · 0 comments
Closed

Make lupa and aioredis optional dependencies #15

cunla opened this issue May 24, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@cunla
Copy link
Owner

cunla commented May 24, 2022

See discussion on #13. lupa and aioredis should be optional dependencies.

  • Make lupa and aioredis optional in pyproject.toml
  • Create a test scheme where lupa is not installed.

I see that in #12 you migrated to poetry, where before you did have lupa and aioredis as optional in your setup.cfg:

[options.extras_require]
lua =
    lupa
aioredis =
    aioredis

but it doesn't seem to be the case in the pyproject.toml today with Poetry, unless there is some different way that I'm not aware of to mark them as optional. As per the poetry documentation that's how extras are 'expected' to be defined at least - if there's a different way it's specified in this project then I'd love to learn about that.

@cunla cunla added the enhancement New feature or request label May 24, 2022
@cunla cunla closed this as completed in 62133d2 May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant