Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The newest release 2.26.0 does not work with Python 3.7 #341

Closed
not522 opened this issue Oct 25, 2024 · 5 comments
Closed

The newest release 2.26.0 does not work with Python 3.7 #341

not522 opened this issue Oct 25, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@not522
Copy link

not522 commented Oct 25, 2024

Describe the bug
Thanks for your great project!
I found the newest release 2.26.0 does not work with Python 3.7.

To Reproduce

>>> import fakeredis
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/not/.pyenv/versions/fakeredis/lib/python3.7/site-packages/fakeredis/__init__.py", line 3, in <module>
    from ._connection import (
  File "/Users/not/.pyenv/versions/fakeredis/lib/python3.7/site-packages/fakeredis/_connection.py", line 8, in <module>
    from ._server import FakeBaseConnectionMixin, FakeServer, VersionType
  File "/Users/not/.pyenv/versions/fakeredis/lib/python3.7/site-packages/fakeredis/_server.py", line 6, in <module>
    from typing import Dict, Tuple, Any, List, Optional, Union, Literal
ImportError: cannot import name 'Literal' from 'typing' (/Users/not/.pyenv/versions/3.7.8/lib/python3.7/typing.py)

Expected behavior

Screenshots

Desktop (please complete the following information):

  • OS: iOS
  • python version: 3.7.8
  • redis-py version: 2.26.0
  • full requirements.txt?

Additional context

@not522 not522 added the bug Something isn't working label Oct 25, 2024
@kloczek
Copy link

kloczek commented Oct 25, 2024

Python 3.7 is already EOSed https://endoflife.date/python.

@cunla
Copy link
Owner

cunla commented Oct 25, 2024

While it is not officially supported, I can publish a fix for this.

@cunla cunla mentioned this issue Oct 25, 2024
@cunla
Copy link
Owner

cunla commented Oct 25, 2024

Will publish a fix soon.

@cunla cunla closed this as completed Oct 25, 2024
@szokeasaurusrex
Copy link

@cunla any plans to release this fix soon?

szokeasaurusrex added a commit to getsentry/sentry-python that referenced this issue Oct 28, 2024
`fakeredis` `2.26.0` [broke on Python 3.6 and 3.7](cunla/fakeredis-py#341). A fix should be available when the next version is available.
szokeasaurusrex added a commit to getsentry/sentry-python that referenced this issue Oct 28, 2024
`fakeredis` `2.26.0` [broke on Python 3.6 and 3.7](cunla/fakeredis-py#341). A fix should be available when the next version is available.
szokeasaurusrex added a commit to getsentry/sentry-python that referenced this issue Oct 28, 2024
`fakeredis` `2.26.0` [broke on Python 3.6 and 3.7](cunla/fakeredis-py#341). A fix should be available when the next version is available.
@cunla
Copy link
Owner

cunla commented Oct 28, 2024

Released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants