-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add nowait for asyncio disconnect #76
fix: add nowait for asyncio disconnect #76
Conversation
Can you add a test for it? |
@cunla |
Thx for writing this, but the test does not test the |
I don't know what should I do.. should I have to test nowait of redis-py? |
Hi, as you can see, tests fail for redis-py below 4.4. |
It passes, the failure is due to a github action bad permissions which I will fix separately. |
please check this.
relative pr redis/redis-py#2356
without this, you can meet this
redis/asyncio/connection.py:767: TypeError