Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespaced keyword "Navigate to Declaration" and "Find Usages" do not work outside of CLJC files #1913

Closed
shaunparker opened this issue Dec 6, 2017 · 2 comments
Labels
bug Marks issues describing bugs released Marks issues which have had the fixes released in a stable build
Milestone

Comments

@shaunparker
Copy link

Clojure Spec definitions defined in CLJC files do not work with "Navigate to Declaration" or "Find Usages" in CLJ and CLJS files.

Steps to reproduce:

  1. Create specs.cljc
(ns specs
  (:require [clojure.spec.alpha :as s]))

(s/def ::name string?)

(def the-best-person
  {::name "Jane"})
  1. Create example.clj
(ns example
  (:require [specs :as specs]))

(def people
  [{::specs/name "John"}
   {::specs/name "Jane"}])
  1. From example.clj navigating to the ::specs/name declaration doesn't work. Viewing the usage only shows the two usages in the example namespace.

screenshot 2017-12-06 15 32 55

  1. From specs.cljc file, navigating to the ::name declaration works, but finding usages only shows the usage in the CLJC file, not the two in example.clj.

screenshot 2017-12-06 15 33 56

  1. Convert specs.cljc to CLJ.

  2. "Navigate to Declaration" and "Find Usages" work properly.

screenshot 2017-12-06 15 37 15

screenshot 2017-12-06 15 36 42

@konstan
Copy link

konstan commented Apr 16, 2018

The issue id still there with

Cursive 1.7.0-eap1-2018.1

on

IntelliJ IDEA 2018.1 (Community Edition)
Build #IC-181.4203.550, built on March 26, 2018
JRE: 1.8.0_152-release-1136-b20 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
macOS 10.12.6

Not being able to properly browse through the definitions on complex projects creates a lot of unnecessary friction by requiring to do manual full-text searches / browsing. Would be cool to have a fix for that. Thanks.

@shaunparker
Copy link
Author

Any updates on this? I'd really love to be able to not have to do this navigation manually.

Thanks,
Shaun

@cursive-ide cursive-ide added this to the 1.8.2 milestone May 22, 2019
@cursive-ide cursive-ide modified the milestones: 1.8.2, 1.8.2-eap4 May 24, 2019
@cursive-ide cursive-ide added the bug Marks issues describing bugs label Sep 22, 2020
@cursive-ide cursive-ide added the released Marks issues which have had the fixes released in a stable build label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Marks issues describing bugs released Marks issues which have had the fixes released in a stable build
Projects
None yet
Development

No branches or pull requests

3 participants