Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -r at end of parameters rather than beginning #2059

Closed
cursive-ide opened this issue Sep 28, 2018 · 1 comment
Closed

Add -r at end of parameters rather than beginning #2059

cursive-ide opened this issue Sep 28, 2018 · 1 comment
Labels
bug Marks issues describing bugs released Marks issues which have had the fixes released in a stable build
Milestone

Comments

@cursive-ide
Copy link
Owner

Reported via email:

I am trying to execute clojure.main REPL based on deps.edn alias which has :main-opts key running figwheel REPL like this

:aliases   {:hub {:main-opts ["-m" "figwheel.main"
                              "-o" "resources/public/cljs/hub.js"
                              "-b" "hub"
                              "-r"]
                  :extra-deps {com.bhauman/figwheel-main {:mvn/version "0.1.9"}}}}}

From bash I just do "clj -Ahub" and have a nice figwheel REPL, the command ends up running as:

clojure.main -m figwheel.main -o resources/public/cljs/hub.js -b hub -r

Cursive ends up running REPL with following command line:

clojure.main -r -m figwheel.main -o resources/public/cljs/hub.js -b hub -r

which just starts regular clojure.main REPL, without figwheel, because of the first -r

@cursive-ide cursive-ide added this to the 1.8.0-eap8 milestone Sep 28, 2018
@cursive-ide
Copy link
Owner Author

This is fixed for the next build. The logic is now: if deps supplies any main-opts, they will be added. Then if the run configuration has any parameters (the "Parameters" field) then they will be added. If neither of the above supply any, Cursive will add -r. Similar logic is implemented for the other REPL types.

@cursive-ide cursive-ide added the bug Marks issues describing bugs label Sep 22, 2020
@cursive-ide cursive-ide added the released Marks issues which have had the fixes released in a stable build label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Marks issues describing bugs released Marks issues which have had the fixes released in a stable build
Projects
None yet
Development

No branches or pull requests

1 participant