Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for :extend-via-metadata in protocol definitions #2085

Closed
vlaaad opened this issue Nov 17, 2018 · 3 comments
Closed

Add support for :extend-via-metadata in protocol definitions #2085

vlaaad opened this issue Nov 17, 2018 · 3 comments
Labels
new Marks issues describing new features released Marks issues which have had the fixes released in a stable build
Milestone

Comments

@vlaaad
Copy link

vlaaad commented Nov 17, 2018

With release of 1.10.0-beta6 behavior for metadata-based protocol extension is now opt-in and requires to supply option to enable it:

(defprotocol Component
  :extend-via-metadata true
  (instance [this] "returns platform instance associated with this component"))

After adding :extend-via-metadata true Cursive can't see method declarations:

I hope Cursive will get support for this one day!

@cursive-ide cursive-ide added this to the 1.8.0-eap-11 milestone Nov 17, 2018
@vlaaad
Copy link
Author

vlaaad commented Nov 19, 2018

You are awesome, Colin, thank you!

@sooheon
Copy link

sooheon commented Jun 3, 2019

Not sure if there has been a regression, but with v1.8.2-eap4-2019.1, I still see this issue:

Screen Shot 2019-06-03 at 2 52 24 PM

@jffry
Copy link

jffry commented Sep 12, 2020

@sooheon If you're still having this issue, I narrowed down the cause. Try moving :extend-via-metadata true after the docstring for the defprotocol and Cursive should understand it. I opened a related issue for this: #2429

@cursive-ide cursive-ide added bug Marks issues describing bugs new Marks issues describing new features and removed bug Marks issues describing bugs labels Sep 22, 2020
@cursive-ide cursive-ide added the released Marks issues which have had the fixes released in a stable build label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new Marks issues describing new features released Marks issues which have had the fixes released in a stable build
Projects
None yet
Development

No branches or pull requests

4 participants