Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps.edn with metadata does not import #2155

Closed
danieroux opened this issue Apr 17, 2019 · 2 comments
Closed

deps.edn with metadata does not import #2155

danieroux opened this issue Apr 17, 2019 · 2 comments
Labels
bug Marks issues describing bugs released Marks issues which have had the fixes released in a stable build
Milestone

Comments

@danieroux
Copy link

Opening this deps.edn as a project:

{:deps {^:depot/ignore org.clojure/clojure {:mvn/version "1.10.1-beta2"}}}

Fails with:

Screenshot 2019-04-17 at 10 52 12

For background, this metadata is for https://github.com/Olical/depot

@cursive-ide cursive-ide added this to the 1.8.2 milestone Apr 17, 2019
@voj
Copy link

voj commented May 2, 2019

Metadata is not actually legal EDN https://github.com/edn-format/edn

@cursive-ide
Copy link
Owner

While I think that's true according to the spec, it does seem to work:

Clojure 1.7.0
(clojure.edn/read-string "{:deps {^:depot/ignore org.clojure/clojure {:mvn/version \"1.10.1-beta2\"}}}")
=> {:deps {org.clojure/clojure {:mvn/version "1.10.1-beta2"}}}

@cursive-ide cursive-ide modified the milestones: 1.8.2, 1.8.2-eap3 May 18, 2019
@cursive-ide cursive-ide added the bug Marks issues describing bugs label Sep 22, 2020
@cursive-ide cursive-ide added the released Marks issues which have had the fixes released in a stable build label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Marks issues describing bugs released Marks issues which have had the fixes released in a stable build
Projects
None yet
Development

No branches or pull requests

3 participants