Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Prismatic Schema #319

Closed
hlship opened this issue Mar 19, 2014 · 21 comments
Closed

Support Prismatic Schema #319

hlship opened this issue Mar 19, 2014 · 21 comments
Milestone

Comments

@hlship
Copy link

hlship commented Mar 19, 2014

It would be nice if Cursive could "magically" recognize Prismatic Schema and it's variations on def and defn, etc. Probably the same for core.typed.

@cprice404
Copy link

+1 on prismatic schema, that would be outstanding!

@cursive-ide
Copy link
Owner

Yes, I'm planning to do this very soon. Core.typed is already basically done, I think, although the support isn't very intelligent yet - just ignores the core.typed symbols so the inspector doesn't complain.

@KevinCorcoran
Copy link

+1 for schema support, especially schema.core/defn

@ghost
Copy link

ghost commented Apr 30, 2014

I too would really enjoy this. 👍

@camlow325
Copy link

👍

@cursive-ide cursive-ide added this to the Shortlist milestone May 23, 2014
@dankreek
Copy link

👍 Please add this!

@alexanderkiel
Copy link

It would be also nice to support fnk and defnk. Thanks.

@KevinCorcoran
Copy link

Hi,

Is there any sort of timeline for this issue?

We use schema heavily, and this is, by far, my biggest gripe with cursive right now. IIRC, some of IDEA's actions used to work on schema stuff (go to symbol, file structure, not highlighting everything as unrecognized symbols, etc.), and even just restoring that basic functionality would be a huge improvement for me. As it stands, I'm basically reduced to just text search to get around (since our heavy usage of schema makes those more advanced actions basically unusable), and most of the code I work on looks like a kid went wild with a highlighter.

Ok, rant over. :) Cursive is awesome.

@lucascs
Copy link

lucascs commented Aug 14, 2014

+1000 for what @KevinCorcoran said

@cprice404
Copy link

me too :)

@cursive-ide
Copy link
Owner

Arg, I'm sorry guys - I'm hoping to get this into the next release but circumstances have meant I haven't had time to work on it. I'll do my best - if not I'll bring out another release shortly to fix this.

@cursive-ide cursive-ide modified the milestones: Shortlist, 0.1.31 Aug 15, 2014
@KevinCorcoran
Copy link

Thanks!

@cursive-ide
Copy link
Owner

Ok, initial support for this is in the next build. It still needs some more work, but it should mostly work. The biggest missing piece is that schema.macros/defrecord is not supported yet. Also some niceties like arglists don't work correctly yet for sm/defn or sm/fn. That said, sm/fn, sm/defn, sm/letfn, sm/def and sm/defschema should all mostly work now, for clj, cljs and cljx.

This was a bit of a rush job because I have to get this build out before the current beta expires, so please let me know if anything is missing or doesn't work correctly. The outstanding items listed above will be fixed in the following build.

@cursive-ide cursive-ide modified the milestones: 0.1.31, 0.1.32 Aug 16, 2014
@KevinCorcoran
Copy link

YES! Thanks again!

@lucascs
Copy link

lucascs commented Aug 16, 2014

Thank you very much!!!

@cursive-ide cursive-ide modified the milestones: 0.1.32, 0.1.33, Shortlist Aug 19, 2014
@Pancia
Copy link

Pancia commented Oct 23, 2014

Any update on getting schema's defrecord supported?

@NoamB
Copy link

NoamB commented Nov 15, 2014

+1 for s/defrecord

@cursive-ide cursive-ide modified the milestones: 0.1.44, Shortlist Jan 5, 2015
@cursive-ide cursive-ide modified the milestones: 0.1.44, 0.1.45 Jan 17, 2015
@cursive-ide cursive-ide modified the milestones: 0.1.45, 0.1.44 Jan 17, 2015
@cursive-ide
Copy link
Owner

This is finally fixed for the next build. s/defrecord is supported, and arglists etc are also supported correctly for all schema forms.

@cprice404
Copy link

Hooray!!!

@tonyvanriet
Copy link

Am I correct in thinking that s/defmethod is still not supported?
The parameters to the s/defmethod are all marked unresolved and the formatting behaves differently.

cursive s-defmethod

@tonyvanriet
Copy link

I see #993 now. Looks like I'm not alone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests