Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly encode spaces in URL #78

Closed
orenbm opened this issue Jun 8, 2020 · 0 comments · Fixed by #79
Closed

Properly encode spaces in URL #78

orenbm opened this issue Jun 8, 2020 · 0 comments · Fixed by #79

Comments

@orenbm
Copy link
Member

orenbm commented Jun 8, 2020

The "encodeUriComponent" method encodes plus signs into %2B and spaces
into '+'. However, our server decodes plus signs into plus signs in the
retrieveSecret request so we need to replace the plus signs (which are
spaces) into %20.

@orenbm orenbm self-assigned this Jun 8, 2020
@orenbm orenbm linked a pull request Jun 8, 2020 that will close this issue
@sgnn7 sgnn7 closed this as completed in #79 Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

1 participant