From c6fb44afde20e41594db494f5c7e062f37543da6 Mon Sep 17 00:00:00 2001 From: Shlomo Heigh Date: Mon, 3 Apr 2023 15:00:11 -0400 Subject: [PATCH] Remove netgo tag to fix Windows hosts file bug --- .goreleaser.yml | 7 ++++++- CHANGELOG.md | 5 +++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/.goreleaser.yml b/.goreleaser.yml index 5b7bcce0..a9968d31 100644 --- a/.goreleaser.yml +++ b/.goreleaser.yml @@ -14,8 +14,13 @@ builds: # Tag 'netgo' is a Go build tag that ensures a pure Go networking stack # in the resulting binary instead of using the default host's stack to # ensure a fully static artifact that has no dependencies. + # However, netgo on Windows has a bug that prevents it from using the + # machine's hosts file for DNS resolution. Therefore this tag must be + # omitted on Windows until the bug is fixed. See + # https://github.com/golang/go/issues/57757 and internal ticket + # CNJR-904 for more information. flags: - - -tags=netgo + - -tags={{ if ne .Os "windows" }}netgo{{ end }} - -a goos: - linux diff --git a/CHANGELOG.md b/CHANGELOG.md index 9b66b500..bf7741a7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. ## [8.0.7] - 2023-04-17 +### Fixed + +- Fixed not using hosts file on Windows + [cyberark/conjur-cli-go#121](https://github.com/cyberark/conjur-cli-go/pull/121) + ## [8.0.6] - 2023-04-17 ### Fixed