From 28451dbef10a87e57d94b788f75745115df711ba Mon Sep 17 00:00:00 2001 From: Shlomo Heigh Date: Mon, 3 Apr 2023 15:00:11 -0400 Subject: [PATCH] Remove netgo tag to fix Windows hosts file bug --- .goreleaser.yml | 7 ++++++- CHANGELOG.md | 9 +++++++-- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/.goreleaser.yml b/.goreleaser.yml index 5b7bcce0..a9968d31 100644 --- a/.goreleaser.yml +++ b/.goreleaser.yml @@ -14,8 +14,13 @@ builds: # Tag 'netgo' is a Go build tag that ensures a pure Go networking stack # in the resulting binary instead of using the default host's stack to # ensure a fully static artifact that has no dependencies. + # However, netgo on Windows has a bug that prevents it from using the + # machine's hosts file for DNS resolution. Therefore this tag must be + # omitted on Windows until the bug is fixed. See + # https://github.com/golang/go/issues/57757 and internal ticket + # CNJR-904 for more information. flags: - - -tags=netgo + - -tags={{ if ne .Os "windows" }}netgo{{ end }} - -a goos: - linux diff --git a/CHANGELOG.md b/CHANGELOG.md index 9b66b500..312b6745 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,7 +10,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Nothing should go in this section, please add to the latest unreleased version (and update the corresponding date), or add a new version. -## [8.0.7] - 2023-04-17 +## [8.0.7] - 2023-04-18 + +### Fixed +- Fixed not using hosts file on Windows + [cyberark/conjur-cli-go#121](https://github.com/cyberark/conjur-cli-go/pull/121) ## [8.0.6] - 2023-04-17 @@ -72,7 +76,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. ### Added - Placeholder version to capture the reset of the repository -[Unreleased]: https://github.com/cyberark/conjur-cli-go/compare/v8.0.6...HEAD +[Unreleased]: https://github.com/cyberark/conjur-cli-go/compare/v8.0.7...HEAD +[8.0.7]: https://github.com/cyberark/conjur-cli-go/compare/v8.0.6...v8.0.7 [8.0.6]: https://github.com/cyberark/conjur-cli-go/compare/v8.0.5...v8.0.6 [8.0.5]: https://github.com/cyberark/conjur-cli-go/compare/v8.0.4...v8.0.5 [8.0.4]: https://github.com/cyberark/conjur-cli-go/compare/v8.0.3...v8.0.4