Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework integration tests script #166

Closed
3 tasks
telday opened this issue Mar 25, 2021 · 1 comment · Fixed by #184
Closed
3 tasks

Rework integration tests script #166

telday opened this issue Mar 25, 2021 · 1 comment · Fixed by #184

Comments

@telday
Copy link
Contributor

telday commented Mar 25, 2021

Is your feature request related to a problem? Please describe.

The integration test script should be re-worked to include the ability to run new DAP tests, and should be renamed to follow the test_<test type> scheme that most Cyberark projects follow.

That is, instead of having a separate test_enterprise script, we should have one single test_integration script that can be toggled to run tests against either oss or enterprise, and this single script can be invoked in the project pipeline.

As part of this card, we can also review the naming of the utility scripts to make sure that the exact behavior that each script does is clear from the name alone, and that we follow the convention of having bin/test_unit, bin/test_integration, bin/test_e2e, and bin/dev (as needed) so that it's easy for devs starting work on this project to get started. The docs on them will be cleaned up in #164.

Currently the script runs the Python integration tests by default, this should be changed so that users are required to specify a specific set of integration tests.

AC:

  • The test scripts use the common convention of being named bin/test_X, and are consolidated
  • Utility script names are clear
  • The integration test script doesn't have a default language that it runs, but requires a language to be passed in
@telday
Copy link
Contributor Author

telday commented Apr 15, 2021

Additionally I would like to see the way we run a given clients tests change. We currently use a -l <language> flag on the generated client and --<language> on the integration test script. We should bring these in line and add an extra flag to the integration tests script which allows passing a specific test to run.

So running just the secrets tests in Python would be: ./bin/integration_tests -l python --tests test_secrets_api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants