Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit events are present for for user login #1054

Closed
jvanderhoof opened this issue Jun 6, 2019 · 5 comments
Closed

Audit events are present for for user login #1054

jvanderhoof opened this issue Jun 6, 2019 · 5 comments

Comments

@jvanderhoof
Copy link
Contributor

jvanderhoof commented Jun 6, 2019

As a security administrator, I want to know when users successfully or unsuccessfully logged into Conjur, so that I can detect any suspicious behavior.

GIVEN a running Conjur instance with a user
WHEN that user logs in with a valid username and invalid password
THEN an audit message is present in the audit log noting the unsuccessful login attempt
AND WHEN that user logs in with a valid username and valid password
THEN an audit message is present in the audit log noting the successful log in

Developer Notes

  • Audit message should conform to our audit format
  • Audit messages for login (both success and failure) should be unique, and not use the authenticate event.
@h-artzi
Copy link
Contributor

h-artzi commented Mar 23, 2020

The following video shows the audit logs on the Conjur-UI. The steps completed were all done with a valid username.

  1. Login with incorrect password via CLI
  2. Login with correct password via CLI
  3. Login with incorrect password via CLI
  4. Login via the UI
  5. Find the instance where it prints invalid credentials, success, invalid credentials.

Is this the result we were interested in? @jvanderhoof

@micahlee
Copy link
Contributor

micahlee commented Apr 2, 2020

Hey @h-artzi , one thing we should change here is make sure the audit logs use "login" in the failure message, rather than "authentication" since these are two different kinds of events.

@jvanderhoof
Copy link
Contributor Author

The following event is generated on a failed user login:

{
	"subject@43868": {
		"role": "demo:user:admin"
	},
	"auth@43868": {
		"authenticator": "authn"
	},
	"action@43868": {
		"result": "failure",
		"operation": "authenticate"
	},
	"PROGRAM": "conjur",
	"PID": "6a7cad51-11cd-4683-9e2d-4562cee0e4f7",
	"MSGID": "authn",
	"MESSAGE": "demo:user:admin failed to authenticate with authenticator authn: CONJ00002E Invalid credentials",
	"LEVEL": "warning",
	"ISODATE": "2020-04-17T15:53:26.576+00:00",
	"FACILITY": "authpriv"
}

There is nothing more we need to complete.

@micahlee
Copy link
Contributor

micahlee commented Apr 17, 2020

@jvanderhoof, the issue is this is the exact same message whether you attempt the /login or the /authenticate action.

These really should be separate audit events. Right now there is no way to distinguish between them, and they are different credentials and endpoints than authenticate.

@jvanderhoof
Copy link
Contributor Author

Thanks for the clarification @micahlee. I'm going to re-open this and add some additional context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants